[Broken Website] Sonarr and radarr

darkreader / darkreader

Dark Reader Chrome and Firefox extension

https://darkreader.org/

MIT License

19.47k stars 2.39k forks source link

[Broken Website] Sonarr and radarr #12661

Open shifoc opened 5 months ago

shifoc commented 5 months ago

Prerequisites

[X] I searched for any existing report about this website issue to avoid opening a duplicate.
[X] I can reproduce this website issue in a new, unmodified web browser profile with Dark Reader installed as the only extension.

Website Issue Description

icons are black

Website Address

it's local websites

Steps To Reproduce

open the website

Screenshots

Operating System

windows

Web Browser name and version

chrome

Dark Reader version

4.9.84

Additional Context

it was working in previous versions

alexanderby commented 5 months ago

Is there any way to see it online? Or maybe you could share downloaded HTML page?

shifoc commented 5 months ago

you can download it from here https://github.com/Sonarr/Sonarr . yes I can send the html do you want it with the extension enabled or not?

alexanderby commented 5 months ago

I think with Dark Reader disabled will be useful. Could you please share it as a file attached?

alexanderby commented 5 months ago

I think I will need the images too. Could you please download it as a page with images and send as ZIP archive?

shifoc commented 5 months ago

Calendar - Sonarr.zip

charmarkk commented 4 months ago

I do not see this issue occurring with Radarr or Sonarr - perhaps there's a different extension or custom style sheet interfering?

Radarr v5.4.6.8723 Sonarr v3.0.10.1567 (didn't have a problem on my test machine with 4.x either) DR v4.9.84

shifoc commented 4 months ago

Are you on the same version as me? Can you try the html I provided?

charmarkk commented 4 months ago

@shifoc Added versions - yes we have the same DR version. I tried downloading the HTML and opening it, DR had no effect on it. ~~Something way in the back of my head is telling me this was an issue with Radarr that was fixed - I feel like I had the same issue a while ago on an old version.~~

Edit: Aha - it's specific to Chrome. Firefox doesn't have this problem. Fwiw, Radarr has its own dark theme, and Sonarr 4 has one now too, so you may not need DR enabled on these.

Edit 2: Fwiw devs, it's this rule that's causing the problem:

[data-darkreader-inline-invert] {
    filter: invert(100%) hue-rotate(180deg);
}

shifoc commented 4 months ago

Yes I know but the dark mode of DR is much better

alexanderby commented 4 months ago

@shifoc Thanks, that was very helpful. I see the SVG analysis becomes tricky, because developers use both external styles and inline styles for SVG images. I will revert my certain change, the fix should be available next week.