darkreader / darkreader

Dark Reader Chrome and Firefox extension
https://darkreader.org/
MIT License
19.69k stars 2.42k forks source link

[Broken Website] GitHub online editor text area is white #12722

Open nic-obert opened 6 months ago

nic-obert commented 6 months ago

Prerequisites

Website Issue Description

When editing a file on GitHub, using GitHub's online text editor, the unwritten part of the editor's text area is white. The part of the text area that actually contains text (including newlines) is correctly displayed as black. However, the remaining portion of the text area, which doesn't contain any text, is displayed as white.

Website Address

https://github.com

Steps To Reproduce

  1. Open any file on GitHub in edit mode with the online text editor

Screenshots

dark_reader_white ArcoLinux_2024-05-14_21-58-02

Operating System

ArcoLinux (arch-based) Kernel 6.8.9-arch1-2

Web Browser name and version

Google Chrome 124.0.6367.201

Dark Reader version

4.9.84

Additional Context

The problem persists after any combination of refreshing the page and disabling/enabling dark mode

oberrich commented 6 months ago

Managed to reproduce on 4.9.84 and 4.9.85 (trunk).

.cm-scroller:before {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller:after {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller {
    background-color: var(--darkreader-neutral-background) !important;
}

This seemed to fix it for me, can you check if this works for you @nic-obert?

nic-obert commented 6 months ago

Managed to reproduce on 4.9.84 and 4.9.85 (trunk).

.cm-scroller:before {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller:after {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller {
    background-color: var(--darkreader-neutral-background) !important;
}

This seemed to fix it for me, can you check if this works for you @nic-obert?

Pasting this CSS in the head > style.darkreader.darkreader--user-agent HTML element works perfectly. The entire editor text area is displayed as black as it should.

Edit:

I figured it would be nice to add a screenshot of the resulting page

fixed