darkreader / darkreader

Dark Reader Chrome and Firefox extension
https://darkreader.org/
MIT License
19.57k stars 2.41k forks source link

Extension has no effect on unstyled backgrounds. #2275

Open jkopczyn opened 4 years ago

jkopczyn commented 4 years ago

As an example of what I mean, see these two views of logs from Chromium development.

The extension, when on, switches the text color to white and (where applicable) the coloration of all other visible elements (images, hyperlinks), but it has no effect on the background, which remains white.

This may be closely related to #2274.

Gusted commented 4 years ago

Does this only persist with chromium site so far I know it has a lot of shadow doms. Could you check If their is the site any #shadow-open element or something. Don't have permissions to logs

FranklinYu commented 4 years ago

These two pages are not available publicly. To get this fixed we probably need a publicly-assessible page.

allenbenz commented 4 years ago

If this is happening on chrome 81 with the Filter/Filter+ engine, this is a manifestation of #2256 There is a workaround posted there

jkopczyn commented 4 years ago

Huh, I thought those pages were public, but you're right, they aren't. I'll look for another example which is public.

I don't know what the Filter engine is, so I don't know if I have it.

Gusted commented 4 years ago

I don't know what the Filter engine is, so I don't know if I have it.

https://darkreader.org/help/en/#theme-generation-modes https://darkreader.org/images/help/darkreader-more-tab.png

jkopczyn commented 4 years ago

That option doesn't show up for me. I tried updating the extension and it still does not show up for me. Chrome 81.0.4044.129. Consistently recurs on both Windows and ChromeOS.

jkopczyn commented 4 years ago

https://www.zellepay.com/go/zelle is also affected and definitely public.

Gusted commented 4 years ago

Could you show an screenshot of what kind of UI you are getting

Gusted commented 4 years ago

Of the Extension of course @jkopczyn