darkreader / darkreader

Dark Reader Chrome and Firefox extension
https://darkreader.org/
MIT License
19.11k stars 2.33k forks source link

[Broken Website] Microsoft Outlook Web Application (OWA) missing buttons in compose email section #9663

Closed timjobutler closed 1 year ago

timjobutler commented 1 year ago

Broken Website Report

Website Address

https://mail.jwpub.org/owa

Steps To Reproduce

Problematic Observation

The buttons in the compose email section, both new and replies, are missing in Dynamic mode but appear when switching to Filter mode. Interestingly, in the Chrome browser, once you have switched to Filter mode to access the buttons if you switch back to Dynamic mode, the buttons remain present. However, this behaviour only works in Chrome, not in Edge or Firefox.

Screenshots

Screenshot of the Compose email section when Dynamic mode is applied owa-dynamic

Screenshot of the Compose email section when Filter mode is applied owa-filter

System Information

Windows 10 Home, 64-bit, Build 19043 Chrome version 104.0.5112.102 Firefox version 103.0.2 Edge version 104.0.1293.63 Dark Reader version 4.9.57

Additional Context

This website is accessed using an organisational Microsoft Exchange account

Gusted commented 1 year ago

Adding help wanted as this seems to be an "internal" page.

timjobutler commented 1 year ago

I am happy to provide whatever technical data is needed since a work account is required to access this page

Gusted commented 1 year ago

When I add a help wanted label, I kind of expect for people with those access to investigate a bit for themselves (as remote debugging is time-consuming and can really lead to nothing as I don't know the whole context). You could investigate via the dev tools(ctrl + shift + i) if there's CSS that's causing this buttons to be not visible (if they are there in the first place).

timjobutler commented 1 year ago

@Gusted I am new to this side of the browser so I will try my best to provide the info.

UPDATE - this issue is only present in Firefox (version 104.0.1)

Screenshot of "Bold" button in Dynamic mode mail jwpub org - Bold button (Dynamic mode)

Screenshot of "Bold" button in Filter mode mail jwpub org - Bold button (Filter mode)

Screenshots of Developer Tools for the "Bold" button mail jwpub org - Bold button - Dev Tools 1

mail jwpub org - Bold button - Dev Tools 2

Here is the CSS code for the "Bold" button as a sample OWA.txt

Here is the page source HTML file, not sure if it is helpful or not https __mail.jwpub.orgowa#path=_mail_drafts.txt

Gusted commented 1 year ago

Could you please make a screenshot with the <span class="_fc_3 owaimg csimg image-bold-png"> element being selected?

timjobutler commented 1 year ago

Hi @Gusted

Here is the screenshot of the <span class="_fc_3 owaimg csimg image-bold-png"> element selected.

span class=''_fc_3 owaimg csimg image-bold-png'' element

Gusted commented 1 year ago

Thanks! Could you scroll down the element's style rules?

image

Somewhere in that list, there's likely a rule that's causing this. If you're not able to figure that out, please send a screenshot of all rule(the first 25 should be enough).

timjobutler commented 1 year ago

I believe these are the screenshots you are requesting.

element-rules-1

element-rules-2

element-rules-3

Gusted commented 1 year ago

Interesting, seems to be correct. Could you try adding this custom fix to Dark Reader's devtools:

mail.jwpub.org/owa

IGNORE IMAGE ANALYSIS .image-bold-png

================================


- Try to format this fix as the other fixes, don't just copy paste it. Dark Reader will automatically sort the fix alphabetically, just make sure it's according to current format.
- Click Apply
timjobutler commented 1 year ago

I have added the suggested fix in the Dev Tools and expanded it to include all the buttons that were not visible. The fix is below.

================================

mail.jwpub.org/owa

IGNORE IMAGE ANALYSIS
.image-font-png
.image-font_size-png
.image-bold-png
.image-italic-png
.image-underline-png
.image-backcolor-png
.image-forecolor-png
.image-insertunorderedlist-png
.image-insertorderedlist-png
.image-outdent-png
.image-indent-png
.image-justifyleft-png
.image-justifycenter-png
.image-justifyright-png
.image-createlink-png
.image-unlink-png
.image-superscript-png
.image-subscript-png
.image-strikethrough-png
.image-alttext-png
.image-blockdirltr-png
.image-blockdirrtl-png
.image-undo-png
.image-redo-png
.image-removeformat-png
.image-table_icon-png
.image-insertpicture-png
.image-emoji-png
.image-format-png

================================

Below is a screenshot of the same page with the fix applied. mail jwpub org fix

I hope this data is helpful and could be added to all sessions of Dark Reader.

Thanks for your patience @Gusted

Gusted commented 1 year ago

Fantastic @timjobutler! The fix will be added via #9872, many thanks for your collaborative response.

tbloch1 commented 7 months ago

This issue also affects my outlook web app. The solution provided does work if I change the web address accordingly. However, is there not some wild-card solution that can be implemented so that the solution works across different instances of OWA, without having to manually add in the exceptions for each one?