search

darkrenaissance / darkfi

Anonymous. Uncensored. Sovereign.
https://dark.fi
GNU Affero General Public License v3.0
1.13k stars 120 forks source link

Bitcoin deposit address #17

Closed taxmeifyoucan closed 2 years ago

taxmeifyoucan commented 3 years ago

Is there specific reason for using P2PKH addresses for deposits? bitcoin rust library offers P2wpkh, P2wsh formats. For this use case, LNP-BP might be useful https://github.com/LNP-BP/rust-lnpbp which also supports p2tr.

In testnet setup, I see that after deposit, btc transaction is instantly sent to wallet n3EvryUzcWNpJ6FRqmoxrRLytBar5GAQfC which is reused many times. Is there any docs which would explain this process? It seems like unnecessary privacy leak.

philippnagel commented 2 years ago

I tried a quick search in the repo but it seems like the address isn't hardcoded. Would be great to get an explanation :)

parazyd commented 2 years ago

We started with such a design and it will be improved. If you read the code you can basically see what's going on in https://github.com/darkrenaissance/darkfi/blob/master/src/service/btc.rs

We'll see what we can do for the next steps.

ghassmo commented 2 years ago

we are switching to a new bridge for bitcoin