darkrenaissance / darkfi

Anonymous. Uncensored. Sovereign.

https://dark.fi

GNU Affero General Public License v3.0

1.07k stars 114 forks source link

Installation Instructions Missing `libclang-dev` #236

Closed bonedaddy closed 10 months ago

bonedaddy commented 10 months ago

Overview

The installation instructions are missing the libclang-dev dependency from the list of dependencies which need to be installed.

aggstam commented 10 months ago

Hello @bonedaddy ,

Can you please specify your os/distro? This package should come as a dep to gcc which is in the dependencies table and dependency_setup script.

bonedaddy commented 10 months ago

NAME="Pop!_OS"
VERSION="22.04 LTS"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 22.04 LTS"
VERSION_ID="22.04"

kernel

Linux pop-os 6.5.6-76060506-generic #202310061235~1697396945~22.04~9283e32 SMP PREEMPT_DYNAMIC Sun O x86_64 x86_64 x86_64 GNU/Linux

I installed the dependencies manually so that might be why

aggstam commented 10 months ago

Manually installation was not the root issue. PoP!_OS seems to have split libclang-dev and not ship it as default, hence why it was "missing" from your OS. This is a derivative distro modification, therefore this is not the case for upstream debian (or normal derivatives). I don't see a need to add it as a dependency, or add it in the dependencies setup script, as those assume upstream apt using distros, therefore closing this ticket. Happy to provide any further assistance!

bonedaddy commented 10 months ago

Ah makes sense thanks for the clarification. Yea I wouldn't bother adding it to the dependencies setup script since i doubt a lot of people will be using PoP!_OS.