fix(react): typescript and react version compatibility

darkroomengineering / lenis

How smooth scroll should be

https://lenis.darkroom.engineering

MIT License

7.33k stars 316 forks source link

fix(react): typescript and react version compatibility #321

Closed DaniAcu closed 2 months ago

DaniAcu commented 3 months ago

I found this 2 mistakes, first a small miss config in tsconfig and then a lot of typescript errors in the IDE.

I also add a support for react 17,the code is completely compatible but I don't know if is a priority for you guys or not, but I think is cool have this compatibility when is easy to be possible

vercel[bot] commented 3 months ago

@DaniAcu is attempting to deploy a commit to the darkroom Team on Vercel.

A member of the Team first needs to authorize it.

clementroche commented 2 months ago

thx @DaniAcu, it's merged. However "resolveJsonModule": true gives me some error. I commented it for now.

DaniAcu commented 2 months ago

Thanks! Is it happening in building process? I will take a look why is this happend 😄