search

darkroomengineering / lenis

How smooth scroll should be
https://lenis.darkroom.engineering
MIT License
9.13k stars 388 forks source link

Bundle recommended styles #344

Closed xavierfoucrier closed 3 months ago

xavierfoucrier commented 6 months ago

Same as many other libraries (*), it would be nice to bundle the recommended styles inside the package dist folder.

This way we can safely use them like @use 'lenis/dist/styles.scss'; for example. With this kind of import, you can adjust recommended styles when a new package version is released.

(*) I know that lenis is not like no other libraries 🤘🕶️

feledori commented 6 months ago

it so little css, I think its not worth adding it to the bundle. like this everyone can add what they want and wherever they want. just copy and paste.

clementroche commented 6 months ago

Let's see what we can do.

clementroche commented 4 months ago

yo @xavierfoucrier i've just bundled the css sheet, can you take a look ?

https://unpkg.com/browse/lenis@1.1.9/dist/lenis.css

xavierfoucrier commented 3 months ago

Hello @clementroche 👋

I just tested and it's all fine! 👍 Thanks a lot ☀️ 🪴 😊