darkroomengineering / lenis

How smooth scroll should be
https://lenis.darkroom.engineering
MIT License
7.33k stars 316 forks source link

Throws Error with Astro View Transitions in Firefox #348

Open JoyBoy-369 opened 3 weeks ago

JoyBoy-369 commented 3 weeks ago

When I use lenis with astro and enable view-transitions I get the following errors in the browser console after scrolling a couple of times :

Too many calls to Location or History APIs within a short timeframe. router.js:8:17

Uncaught DOMException: The operation is insecure. updateScrollPosition router.js:8 onScrollEnd router.js:409 EventListener.handleEvent* router.js:418 router.js:8 updateScrollPosition router.js:8 onScrollEnd router.js:409 (Async: EventListener.handleEvent)

router.js:418 However, this does not seem to be the case when view transitions is disabled and works fine in safari and chrome I am using lenis astro and gsap. ``` ``` [Minimal Repo](https://stackblitz.com/edit/github-2hpcon-pl262h?file=src%2Fcomponents%2FLayout.astro)

Developer Tools — Astro Framework React Example (forked) - StackBlitz — https://stackblitz.com/edit/github-2hpcon-pl262h?file=src/components/Layout.astro,astro.config.mjs,src/pages/index.astro,package.json - 6 June 2024 - Watch Video

clementroche commented 3 weeks ago

Do you have the same error if you remove Lenis ? It doesn't seems to be related with Lenis at all.

JoyBoy-369 commented 3 weeks ago

@clementroche Nope. I don't get the same error if I remove Lenis. I have put a minimal repo too if you would like to test it out. There is no error if I remove View Transitions too. There seems to be some issue with astro's View Transition but only in firefox

clementroche commented 3 weeks ago

I can't reproduce your issue using your link on Firefox. Lenis doesn't deal with history or location at all so it might come from your implementation.

https://github.com/livewire/livewire/discussions/7746

JoyBoy-369 commented 3 weeks ago

This seems to be in regard to the Astro's View Transition, not Lenis per say. So I should ask the folk at astro for this issue?

clementroche commented 3 weeks ago

I think so