search

darkskyapp / translations

translate Dark Sky API summaries into any language
BSD 2-Clause "Simplified" License
139 stars 112 forks source link

Support Status Properties in Dutch #268

Closed nonrenewable-zz closed 4 years ago

nonrenewable-zz commented 4 years ago

In the near future, the API will begin using the following new properties:

Add support for these properties to Dutch. (Information is available in the README, and examples are visible in /lib/lang/en.js and /test_cases/en.js.)

Tagging @realjax, @cygnus6, and @michaelarnauts if you have an opportunity to take a look!

realjax commented 4 years ago

Hi, On it, but It is not clear to me what this would be "next-hour-forecast-status": "next hour forecasts are $1 due to $2",

What do the variables represent here? The docs say 'we have information to convey about our hyperlocal next-hour forecasts' which also sounds a bit cryptic to me..

ghost commented 4 years ago

Sorry for being cryptic, we'll see what we can do about the docs. In the meantime, perhaps the best example of how these are used are in the English test cases:

https://github.com/darkskyapp/translations/blob/master/test_cases/en.json#L265-L272

  "Next hour forecasts are temporarily unavailable due to all nearby radar stations being offline.":
    ["sentence", ["next-hour-forecast-status", "temporarily-unavailable", "station-offline"]],

  "Next hour forecasts are partially unavailable due to gaps in coverage from nearby radar stations.":
    ["sentence", ["next-hour-forecast-status", "partially-unavailable", "station-incomplete"]],

  "Next hour forecasts are unavailable due to all nearby radar stations being offline.":
    ["sentence", ["next-hour-forecast-status", "unavailable", "station-offline"]]
realjax commented 4 years ago

Ok, thanks for that,clear now :) . I have translated the missing pieces and will create a PR.