search

darksoil-studio / p2p-shipyard

Ship cross-platform p2p apps
http://darksoil.studio/p2p-shipyard/
11 stars 3 forks source link

Modify flake to inject scaffolding version into shipyard #18

Closed c12i closed 1 month ago

c12i commented 3 months ago

Hi @guillemcordoba,

We recently encountered an issue with the current setup guide for the P2P Shipyard development environment, as described in the Darksoil documentation.

Issue:

The current flake setup introduces another level of locking for the scaffolding version. For better stability and maintainability of the scaffolded hApps, I suggest modifying the flake to inject versions directly into Shipyard.

See this thread for reference: https://github.com/holochain/scaffolding/issues/328. A new version of scaffolding was not immediately available for use after running nix flake update; the flake.lock file of this repo would need to be updated first.

guillemcordoba commented 1 month ago

Thanks, fixed in latest master, the shipyard nix does not add the holochain packages in the shell anymore, instead it requires the consuming flake to do so.