Call header_remove only when the function exists (it's 5.3+)

darkstardigital / phpThumbsUp

ModX package for creating dynamic image thumbnails

10 stars 7 forks source link

Call header_remove only when the function exists (it's 5.3+) #19

Closed Majkl578 closed 11 years ago

Majkl578 commented 11 years ago

Probably the only thing blocking usage on PHP 5.2 (yes, it sucks, but i was forced to use shared webhosting w/o 5.3+).

sdwespi commented 11 years ago

Unfortunately without removing the header your images will never be cached by many browsers, which makes images generated by phpThumbsUp very slow. It's unfortunate that you can't upgrade to 5.3+, but we don't want to break caching on 5.2 and advertise that phpThumbsUp works on 5.2 if it performs that badly.

Majkl578 commented 11 years ago

Hmm, wouldn't it be possible to send Expire header, but modify its value (as it can't be removed on 5.2) to something in (distant) future?