darksworm / hearthstone-obs-recorder

Hearthstone Deck Tracker plugin which automatically records your hearthstone games in OBS.
GNU General Public License v3.0
1 stars 2 forks source link

obs websocket is now bundled with obs, any chance for an update? #4

Open Jieiku opened 6 months ago

Jieiku commented 6 months ago

This plugin still works with the older OBS 27.2.4 and 4.9.1-websocket

I am using it with my modified version of this plugin (30 seconds cutoff): https://github.com/Jieiku/hearthstone-obs-recorder/releases

An update to this plugin to work with the latest OBS would be awesome!

Would be nice if the seconds could be configurable in the deck tracker plugin settings window.

When your playing ranked it usually cuts off some of the rank up or down animation.

Thanks for the plugin!

Being new to HS decktracker I did not yet realize how to set the password, in case it helps anyone:

password

You have to also set the matching password in obs websocket under the tools menu:

password2

darksworm commented 5 months ago

I tried to update it but was not successful - upgrading the dependencies breaks the plugin and I am not well versed in c# to figure it out (and don't want to spend more time than I already have on it).

The issue has something to do with how the final DLL is packed, that's as far as I got.

Honestly, I created this plugin with almost zero knowledge of c# or .net and never expected to have to make changes to it 😅

If you would like to give it a shot, please go ahead and create a PR - I will gladly review it!

Jieiku commented 5 months ago

I have no experience with C# and I also do not have Visual Studio.

I enabled the Actions/Workflows on github, so that github would compile any changes for me.

I then edited the seconds line from 10 seconds to 30 seconds so that none of the animation at the end of the game would get chopped off.

https://github.com/Jieiku/hearthstone-obs-recorder/commit/9c62b8e7d6e077bd8c66f948935166acf1c4b98f

https://github.com/Jieiku/hearthstone-obs-recorder/releases

I am actually currently using this with the older OBS studio still, it has worked flawlessly so far.

I see your recent commits, will take a look at them, hopefully the new websockets api does not also require changes.

My motivation for using a newer OBS studio is that StreamFX is now behind a paywall, and there are now open source alternatives for some of the features in StreamFX, but it requires using a newer OBS studio.

kost1kla commented 5 months ago

Just tried this plugin with the older OBS 27.2.4 and it still works!

thanks, didn't think to try an older version - works like a charm, super useful. btw not sure if this is useful but there seems to be some compatibility release for obs 27/28 and websocket v4, maybe it can be useful - https://github.com/obsproject/obs-websocket/releases

maybe a lot of people are not having a easy time migrating and they released some backwards compatible update?

Jieiku commented 5 months ago

The only path forward is to rework this plugin for the newer OBS with the integrated websocket API.

I am using the compat obs-websocket 4.9.1 with OBS 27.2.4 anything newer wont load the websocket, here is 28.1.2:

nope