search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.59k stars 1.13k forks source link

Darktable 3.6.1 Crashes when selecting another image in darkroom #10384

Closed andy-hnq closed 2 years ago

andy-hnq commented 2 years ago

Introduction

Describe the bug/issue

To Reproduce

This seems to be intermittent but I've had several crashes over the past few days. I've had it when switching to a new (.CR2) image in darkroom mode, both when using the thumbnail strip at the bottom and when using the spacebar to move to the next image.

Expected behavior

Should move to the selected image without crashing

Which commit introduced the error

Installed 3.6.1 using darktable-3.6.1-win64.exe downloaded from darktable.org on 2nd Nov. Prior install was 3.4 which was uninstalled using control panel before installing 3.6.1

Platform

Additional context

andy-hnq commented 2 years ago

Maybe a gtk version issue.

I thought that GTK comes from the Darktable build on Win32.

Certainly I see it in a subdirectory under 'darktable/build'.

The backtrace (yesterday) says 'libgtk-3-0.dll 3.24.29.0'

... but if I do file/properties on the one in today's build directory I see '3.24.30.0'

I also kept yesterday's (second) master build - this has the same version.

If I use procexp it says that darktable is using the one in Program Files\darktable\bin ... which is '3.24.30.0'

I've also checked the PATH to see if there are any others but found none. I do have gimp and Inkscape which both have libgtk 2 versions but I dont think these are interfering.

I am puzzled by this!

TurboGit commented 2 years ago

Ok, commit reverted. Please double check that master is ok. Thanks!

andy-hnq commented 2 years ago

My bad. Obvious error... looking at the wrong backtrace file.

The correct backtrace agrees... libgtk-3-0.dll 3.24.30.0

andy-hnq commented 2 years ago

I checked out master and then left another clean build running while doing some other stuff. When I came back to it...

[ 55%] Linking C shared library libdarktable.dll C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/lib_darktable.dir/objects.a(imageio_libraw.c.obj): in function dt_imageio_open_libraw': C:/msys64/home/andy/darktable/src/common/imageio_libraw.c:226: undefined reference tolibraw_open_wfile' collect2.exe: error: ld returned 1 exit status make[2]: [bin/CMakeFiles/lib_darktable.dir/build.make:3322: bin/libdarktable.dll] Error 1 make[1]: [CMakeFiles/Makefile2:2227: bin/CMakeFiles/lib_darktable.dir/all] Error 2 make: *** [Makefile:156: all] Error 2

Will look some more tomorrow.

dterrahe commented 2 years ago

When you do a checkout, do you also run git submodule update --init?

andy-hnq commented 2 years ago

When you do a checkout, do you also run git submodule update --init

No I didn't. Thanks - that fixed the build issue.

FYI this was the output...

$ git submodule update --init
Submodule path 'src/external/LibRaw': checked out '30595a731f3bea78f0410426b73ef3afbd3f64c7'
Submodule path 'src/tests/integration': checked out '4b929fa87b7d8d8a7f99fb0b0905800e2e602a85'

I tried the previously crashing steps on the new build and saw no issues.

dterrahe commented 2 years ago

Could you also please check on a version before 9d8d386 was reverted? Maybe it was innocent and can be included again (rereverted)?

andy-hnq commented 2 years ago

Will do but can you tell me the right git steps to get the relevant version pls?

TurboGit commented 2 years ago

@andy-hnq : Can you try this commit:

$ git checkout c95cd44f20d8d39c8ea039f3023f28105646ba8e
$ ./build.sh

Install and try as usual. TIA.

andy-hnq commented 2 years ago

I built from that commit. It still crashes when deleting the second module instance.

I note that Pascal's instructions say 'build.sh'... I am using the instructions at https://github.com/darktable-org/darktable/blob/master/packaging/windows/BUILD.md and using cmake. Are some of you doing win32 builds with cmake to build an installer and then installing that?

alex6480 commented 2 years ago

I get the same problem on my computer. It happens quite frequently, especially in complex images that are are slow to process. It only crashes when switching images from one to another. The issue has gotten progressively worse. It used to rarely crash, but now it crashes almost every time I switch image.

darktable_bt_1NLZH1.txt darktable_bt_9GY0H1.txt darktable_bt_7L6YH1.txt darktable_bt_FI1AI1.txt darktable_bt_0DS4H1.txt darktable_bt_AGPRI1.txt darktable_bt_H54IC1.txt darktable_bt_YG2PI1.txt darktable_bt_9ZDRI1.txt darktable_bt_4AAVI1.txt darktable_bt_WXD1I1.txt darktable_bt_8GYMI1.txt darktable_bt_5NVWI1.txt darktable_bt_TQG1I1.txt darktable_bt_9MS1I1.txt

I can send some images if you tell me where to send them to, but it doesn't seem to be dependent on the image I edit. I only edit Sony RAWs (.ARW)

TurboGit commented 2 years ago

@alex6480 : We are not interested about 3.8.0 report since 3.8.1 has been released with many fixes. Please try with latest stable version.

alex6480 commented 2 years ago

Thanks for the information. I installed the newest version.

The bug is still reproducible. I think it happens when switching from one image to the next while it is still processing a change on the first. If I don't edit the image, I can switch around without crashes.

EDIT: It happens even if just opening darktable and switching back and forth a few times between images.

darktable_bt_MG5FI1.txt

alex6480 commented 2 years ago

@gi-man Thanks for the suggestion. I couldn't reproduce the issue today, maybe it's because I restarted my computer in-between. I'll make sure to grab a debug log, if it happens again.

alasta4204 commented 2 years ago

Good day. I am getting similar behavior on ubuntu 20.04 Darktable 3.8.1 What happens is that when you hit delete to get rid of a dud image it doesn't work. If you try again, fairly quickly the whole PC freezes as in this screenshot. Clicking delete on the mouse works fine ( that's how I got this screenshot ) Ubuntu is still running according to my Conky, Alt F2 to restart gnome doesn't work and I can't get a terminal with Cntrl alt t or Cntrl alt f1. Cntrl alt f7 takes me to a login window which allows a restart

Darktable 3 8 1 Freeze of UI

TurboGit commented 2 years ago

Should be fixed in #12125.