search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.54k stars 1.13k forks source link

Collection filters apply only to first collection #12174

Closed pasta-farian closed 1 year ago

pasta-farian commented 2 years ago

Did you buy darktable from an application store ?

No

Describe the bug/issue

Collection filters apply only to the first collection

To Reproduce

  1. In lighttable, Select a collection (film roll or folder) containing pictures with a variety of star ratings
  2. Choose "add more images" to expand the selection to a second collection
  3. Select a second collection, also containing pictures with a variety of star ratings
  4. Set the range rating in collection filters to, e.g., 3 stars.

You'll still see all the pictures from the second collection, regardless of their rating.

Expected behavior

You should only see pictures rated with 3 stars.

Platform Please fill as much information as possible in the list given below. Please state "unknown" where you do not know the answer and remove any sections that are not applicable

mlaverdiere commented 2 years ago

I'm also experiencing this (or a similar) problem I think: I'm using a collection preset to only retrieve RAW pictures (with various file extensions, like nef, dng and raf) with red colour label. Now, when I want to filter these pictures with the preset "no stars filter", some pictures with stars are still displayed (but some are discarded, so correctly filtered). I'm not sure yet, but the problem seems to be related to recently starred pictures...

I'm on darktable 4.0.0, with opencl on Fedora 36.

mlaverdiere commented 2 years ago

After some more tests, I confirm that I can reproduce this issue. It's exactly like what is described by the OP: as soon as you have more than one collection selected (or more than one condition set in the collection module), the star filtering is not working. This is probably a regression, as I was not facing this problem in previous versions.

dlobraico commented 1 year ago

Also seeing this issue on Fedora 36.

github-actions[bot] commented 1 year ago

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

pasta-farian commented 1 year ago

This appears to be fixed in 4.2

victoryforce commented 1 year ago

@pasta-farian if this is not an issue anymore, please consider closing it.

pasta-farian commented 1 year ago

I thought I had closed it. Trying again

pasta-farian commented 1 year ago

Closing.