darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.81k stars 1.14k forks source link

Vectorscope RYB view is forgotten after a restart #13263

Closed lbilli closed 1 year ago

lbilli commented 1 year ago

This is a minor issue, still I think it's a regression of current master compared to previous behavior. To reproduce:

This behavior is specific to the RYB view. If, for instance, AzBz view is selected, after a restart the same view is presented.

I checked darktablerc and it does contain the line:

plugins/darkroom/histogram/vectorscope=RYB

yet it seems to be ignored.

Mark-64 commented 1 year ago

Confirmed in current master, while 4.2 works ok. I am currently messing up with vectorscope, will have a look.

Mark-64 commented 1 year ago

git bisect gives the following

82963e7051f7d1e3fbbf95243a10bcb0d83a17de is the first bad commit
commit 82963e7051f7d1e3fbbf95243a10bcb0d83a17de
Author: Pascal Obry <pascal@obry.net>
Date:   Sat Dec 31 12:26:23 2022 +0100

    Reorder the configuration loading.

    We must first load the confgen to ensure that we can sanitize the
    current values based on enum, min, max as described in the XML.

 src/common/darktable.c              |  7 ++++++-
 src/control/conf.c                  | 16 +---------------
 tools/generate_darktablerc_conf.xsl | 14 ++++++++++++++
 3 files changed, 21 insertions(+), 16 deletions(-)

@TurboGit this is for you

lbilli commented 1 year ago

Not sure if relevent but while browsing around I noticed that RYB is not listed among the options of plugins/darkroom/histogram/vectorscope.

TurboGit commented 1 year ago

Indeed, this is due to my change which is correct as it validates the values based on the XML, but the value is missing as hinted by @lbilli so when RYB was selected at restart the default for this enum (u*v*) was selected.

See #13268.