search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.8k stars 1.14k forks source link

Long press to preview duplicate in duplicate manager not always working #13364

Closed europlatus closed 8 months ago

europlatus commented 1 year ago

Describe the bug/issue When a duplicate is created via the duplicate manager, you can long press on the inactive duplicate to see a preview of that image overlaid on top of the active image. However, it is not always working. A long press on the inactive duplicate sometimes does nothing. To restore the functionality, double clicking on the inactive image to make it active should reactivate the preview function.

To Reproduce

  1. With an image open in the darkroom, create a duplicate via the duplicate manager.
  2. The duplicate image should now be active. Do an obvious edit to the new duplicate, such as increase exposure by a couple of stops.
  3. Long press the inactive original image in the duplicate manager.
  4. See if a preview of the inactive image is displayed. This does not work for me.
  5. Double click inactive image.
  6. Long press the other duplicate to see if a preview is displayed. This does work for me.

Expected behavior A long press on the inactive image in the duplicate manager should display a preview of that image at any time. It is currently buggy and intermittently stops working. I can reproduce the issue but have not managed to work out if there's a consistent reason when the feature stops working.

Screencast If no one else can reproduce, I can take a video.

Which commit introduced the error Only noticed this since release 4.2.0. I never noticed the problem in earlier versions.

Platform

Additional context

pehar1 commented 1 year ago

Not able to reproduce. The first time "long clicking" the inactive version it takes about 2 seconds (on my system) until the inactive image is shown, after that the overlay appears almost immediately.

darktable 4.3.0-245-gbf38c1a9e OS : Linux 5.15.0-46-generic / Ubuntu 22.04.1 LTS Memory : MemTotal: 65773056 kB Graphics Card : Product Name : NVIDIA GeForce RTX 2060 Graphics Card : Driver Version : 470.161.03 OpenCL installed : Device OpenCL C Version OpenCL C 1.2 OpenCL activated : yes Xorg : Version: 1:7.7+23ubuntu2 Desktop : LXQt GTK+ : 3.24.33 gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0 CMAKE_BUILD_TYPE : release

europlatus commented 1 year ago

Not able to reproduce. The first time "long clicking" the inactive version it takes about 2 seconds (on my system) until the inactive image is shown, after that the overlay appears almost immediately.

If you have the time, it would be great if you could keep trying after various edits and at random points in your workflow. I'm trying to find a 100% reproducible way of seeing this problem, but not sure I've found it yet. It seems to be intermittent, but very frequent for me. For the record, I have kept the long press down for up to 30 seconds to see if it's just a processing lag, but the preview still won't show. And my CPU/GPU are plenty fast enough. Of course, this could be an AMD Radeon or Windows issue...

europlatus commented 1 year ago

Video of the issue:

https://user-images.githubusercontent.com/89879133/213261631-7e265526-f53c-4bc9-bf0c-386c7e033bc3.mp4

Mouse clicks are audible if you have enough volume

pehar1 commented 1 year ago

Still not reproduced.

could be an AMD Radeon ... issue...

You can check if something changes disabling OpenCL in preferences.

or Windows issue...

You could launch darktable from the command line with enabled debug output (https://darktable-org.github.io/dtdocs/en/special-topics/program-invocation/darktable/) and you can compare the outputs when it works and when it doesn't work. This can be a bit tedious....

plougastel commented 1 year ago

I can confirm the bug, which came with 4.2.0 and remains with 4.2.1, for tif pictures not raw ones for me, and not every time with the sames pictures (the duplicate manager was improved in 4.2.0).

Self compiled dt in Gnu/linux, without openCL, Intel video.

europlatus commented 1 year ago

I have been using darktable for a couple of days with openCL off and the bug still happens randomly, so likely not an openCL issue.

Nilvus commented 1 year ago

I can't reproduce on my side (using actual master).

TurboGit commented 1 year ago

I think it works but it may be slow... You need to keep the button pressed until the preview is created and displayed. At this point the clone preview is cached and it should be fast. The issue is that there is no visual feedback about the clone preview being created.

europlatus commented 1 year ago

I think it works but it may be slow...

I held the mouse button down for over 30 seconds before giving up. When it works, it is almost instantaneous. I have just tried it again today but was unable to reproduce. It's an intermittent problem for me.

plougastel commented 1 year ago

The same as @europlatus, intermittent problem, when this works it is rapidly, or not at all.

github-actions[bot] commented 1 year ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] commented 8 months ago

This issue was closed because it has been inactive for 300 days since being marked as stale. Please check if the newest release or nightly build has it fixed. Please, create a new issue if the issue is not fixed.