darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.54k stars 1.13k forks source link

Panasonic DC-S5M2 Raw files not loading #13511

Open dgermin2 opened 1 year ago

dgermin2 commented 1 year ago

I uploaded a sample raw file to raw.pixls.us but I don't see how I can reference it so hopefully you can find it. The Panasonic Lumix S5 Mark II is a brand new camera and it seems the format has changed.

The raw files can be added to lighttable and show all the media information but I get an error message when switching to darkroom telling me the file is not supported and it switches back to the lighttable screen.

This was done with the latest darktable download 4.2.0.

Let me know if I can provide anything else.

Thanks!!!!

kmilos commented 1 year ago

Thanks for the samples! (They go through a manual review process, so don't appear straight away.)

As the camera is so new, it'll probably take while... See also https://github.com/darktable-org/rawspeed/issues/367

dgermin2 commented 1 year ago

Thanks for the info. On Feb 3, 2023, at 12:09 AM, Miloš Komarčević @.***> wrote: As the camera is so new, it'll probably take while... See also darktable-org/rawspeed#367

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

LebedevRI commented 1 year ago

Is the camera actually called DC-S5M2?

kmilos commented 1 year ago

@dgermin2 It would also be good to have the 96MP high-res sample please (and any other modes that output raw). Also, it would seem 12-bit raw is also produced when shooting burst, so that would be good to have as well.

Is the camera actually called DC-S5M2?

Indeed, the issue title needs an update...

JaviMat commented 1 year ago

Hi there, I just saw this issue after uploading raw files myself for the same reason. In my uploads I included all Crops,a High resolution file and two Pictures taken in the burst modes H and HS as well. I will try to get into the White balance presets as well. I am willing to help as well if anything else is needed!

Nilvus commented 1 year ago

@LebedevRI (or @dgermin2): title needs to be updated. Name remains inverted, even after title update. I can't do that myself.

MrLimatex commented 1 year ago

Any news regarding this?

cbnroadmaster commented 1 year ago

This is also with my DC-S5M2x. RAW-Files can be seen in the preview, but can not be loaded to be processed. I can not attach any example, because Your box does not allow the fileformat RW2 and the original file is also too big.

MrLimatex commented 11 months ago

Guys, any news? I don‘t want to spend more money on Lightroom …

brettalcox commented 11 months ago

@MrLimatex you and me both!

cbnroadmaster commented 11 months ago

I bought a proper Lightroom Classic Version for just 20 €.

It works perfekt with the new files: https://mskauf.de/product/adobe-lightroom-classic-2023-vollversion_sofortversand/

It is a shame, that after so many years I realy have to go into Lightroom.

But I have to continou working.

 

Regards

Chris  

--

   

Gesendet: Donnerstag, 19. Oktober 2023 um 18:14 Uhr Von: "MrLimatex" @.> An: "darktable-org/darktable" @.> Cc: "cbnroadmaster" @.>, "Comment" @.> Betreff: Re: [darktable-org/darktable] Panasonic DC-S5M2 Raw files not loading (Issue #13511)

 

Guys, any news? I don‘t want to spend more money on Lightroom …

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

kmilos commented 11 months ago

It is a shame, that after so many years I realy have to go into Lightroom.

Please feel free to let Panasonic know how you feel.

And there is always the intermediate solution of conversion to DNG.

brettalcox commented 10 months ago

@kmilos I uploaded every aspect ratio to raw.pixls.us (4:3, 3:2, 16:9, 65:24, 1:1, and 2:1). Additionally I've uploaded them here https://github.com/brettalcox/dc-s5m2-samples. Is this sufficient?

kmilos commented 10 months ago

@brettalcox Thanks, but I think samples are not the bottleneck at this point.

elenaeli commented 1 week ago

Any update on this? It's September 2024 and I just got my DC-S5II, still not working with Darktable.

jcampbell05 commented 1 week ago

Latest Libraw snapshot now has support, you can build your own copy of darktable with the latest libraw

cbnroadmaster commented 1 week ago

How can I do it ?-- Diese Nachricht wurde von meinem Android Mobiltelefon mit WEB.DE Mail gesendet.Am 09.09.24, 05:42 schrieb James Campbell @.***>:

Latest Libraw snapshot now has support, you can build your own copy of darktable with the latest libraw — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

jcampbell05 commented 1 week ago

Just update the commit for the libraw submodule to the commit of the snapshot and follow the darktable build instructions in the README

cbnroadmaster commented 1 week ago

Thank You.I will try IT Out.-- Diese Nachricht wurde von meinem Android Mobiltelefon mit WEB.DE Mail gesendet.Am 09.09.24, 11:02 schrieb James Campbell @.***>:

Just update the commit for the libraw submodule to the commit of the snapshot and follow the darktable build instructions in the README — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

elenaeli commented 1 week ago

Just update the commit for the libraw submodule to the commit of the snapshot and follow the darktable build instructions in the README

Can you please describe how to do this? I've done the README for the custom installation of Darktable on macos, but I'm unable to find where to update the libraw submodule version.

kmilos commented 1 week ago

Just update the commit for the libraw submodule to the commit of the snapshot

FYI, both the darktable-4.8.x and master branches are already pointing to a recent enough LibRaw snapshot.

jcampbell05 commented 1 week ago

I updated my copy of darktable and I also needed to patch the supported files check to allow libraw to open any RAW file that Rawspeed fails to open. Right now darktable only uses it to open CR3s

https://github.com/darktable-org/darktable/blob/master/src/imageio/imageio_libraw.c#L280

kmilos commented 1 week ago

There is no patching whatsoever necessary w/ 4.8.x or master branch (and building w/ default -DDONT_USE_INTERNAL_LIBRAW=OFF), just the change to the user darktablerc.

Again, please note that this is an unsupported, temporary workaround.

jcampbell05 commented 1 week ago

It is required because Darktable only uses Libraw for files which end in the file extensions "cr3" even when you ask Darktable to use the system version of Libraw - I know because I had to do this in order for it to try and open my RW2 files.

In my last comment I linked to the precise bit of Darktable's code where it does this check, here is a screenshot for convenience. Patching it to always return true allows Darktable to open it in Libraw when Rawspeed fails otherwise it tries to open the RW2 in the QOI image loader after trying Rawspeed

Screenshot 2024-09-13 at 11 26 46 Screenshot 2024-09-13 at 11 30 24
kmilos commented 1 week ago

It is required ...

Please check again. The darktablerc workaround verifiably works w/o any code changes.

even when you ask Darktable to use the system version of Libraw

It most likely does not work w/ system LibRaw, as those are probably too old (i.e. last stable 0.21.x doesn't support GH6/S5M2/G9M2). dt has to be built w/ -DDONT_USE_INTERNAL_LIBRAW=OFF for these, which points a to a more recent snapshot.

victoryforce commented 1 week ago

It is required because Darktable only uses Libraw for files which end in the file extensions "cr3"

@jcampbell05 This is not true. No need to patch check for supported files. Please read the function code carefully. Just add the desired file extensions to the libraw_extensions key in the darktablerc configuration file.

jcampbell05 commented 1 week ago

Ah nice so if I build libraw from my own source code then only thing I need to do is compile with LIBRAW off and update the config file

Much easier than I thought, sorry for confusion was a bit hard to follow initially.

kmilos commented 1 week ago

I need to do is compile with LIBRAW off

Not "LIBRAW off" (it's enabled regardless), but -DDONT_USE_INTERNAL_LIBRAW=OFF (the default anyway so you don't even have to specify it), which, as an unfortunate double negation, means "internal LibRaw on", i.e. not using system LibRaw.

Distros might choose to package w/ explicit -DDONT_USE_INTERNAL_LIBRAW=ON (like "official" Debian/Ubuntu) if they want to ensure only known system libraries are used.

@victoryforce Maybe we should somehow capture and list how it was built in darktable --version output? Just printing LIBRAW_VERSION_STR ought to be good enough for starters...

jcampbell05 commented 1 week ago

One thing that would be helpful in the darkroomrc is the ability to add a wildcard, for my usecase we want darktable to fallback to libraw but without patching it, it seems we would need to either have a large list of extensions or rename the file to one that is in the list to trick darktable into using it.

kmilos commented 1 week ago

Did I mention this is an unsupported, temporary workaround? 😉 (I.e., not a feature.)

victoryforce commented 1 week ago

@victoryforce Maybe we should somehow capture and list how it was built in darktable --version output?

You mean library version? Because the build type (in-tree source/system library) does not carry practically useful information for the user.

Just printing LIBRAW_VERSION_STR ought to be good enough for starters...

Sure, will do.

elenaeli commented 6 days ago

It is required because Darktable only uses Libraw for files which end in the file extensions "cr3"

@jcampbell05 This is not true. No need to patch check for supported files. Please read the function code carefully. Just add the desired file extensions to the libraw_extensions key in the darktablerc configuration file.

Sorry but this doesn't work for me at least on my two Macs - one with M1, one with Intel core. I downloaded latest darktable nightly built, added "rw2" in darktaberc file line libraw_extensions. Any other ideas? What I also tried yesterday is build the darktable according to README for Mac, I manage to build the code after installing 100 dependencies with brew. Then after it ran, opening RW2 file and it just crashes. I could open Sony raw files...

kmilos commented 6 days ago

Any other ideas?

Did you remove previously failed imported files from the database, and their xmp sidecars from disk?

elenaeli commented 5 days ago

Any other ideas?

Did you remove previously failed imported files from the database, and their xmp sidecars from disk?

No, I will try that tomorrow. It doesn't help. I deleted whole database, data.db and library.db files, same..

jcampbell05 commented 5 days ago

Did I mention this is an unsupported, temporary workaround? 😉 (I.e., not a feature.)

I understand for my use case I'm happy to maintain myself.