darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.69k stars 1.14k forks source link

Copy/paste of the history stack does not work on Windows #13531

Closed savchenko closed 1 year ago

savchenko commented 1 year ago

To Reproduce

  1. Install latest release, v4.2.0 at the time of writing
  2. Import several photos
  3. Select a photo in the Lighttable view and press Ctrl+c
  4. Darktable performs "zoom out" instead of "copy history.

Expected behavior History is copied via Ctrl+c and pasted by Ctrl+v as per manual.

Additional notes There were some suspicious shortcuts in settings. After removing them, pressing Ctrl+c yields this:

I am using regular en_AU.UTF-8 keyboard layout.

Trying to remap shortcuts manually, reveals that ctrl+0xffffff is triggered by both Ctrl+c and Ctrl+v.

Additionally, tryiing to use this arguably broken key designation nets this:

It's almost like all characters return 0xffffff for no reason.

Platform

Additional context

github-actions[bot] commented 1 year ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

victoryforce commented 1 year ago

Can't reproduce in either 4.2.0 or the current git version. Please check if this can be reproduced with an empty configuration. It looks like your particular configuration of shortcuts was the cause of the described situation.

github-actions[bot] commented 1 year ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

savchenko commented 1 year ago

@victoryforce , I might be doing something wrong, but this is still an issue when running v4.2.1 on Windows.

Steps to reproduce

  1. Launch Darktable with the new profile (%APPDATA%\darktable)
  2. Import two .ARW files
  3. Switch to the "darkroom" module
  4. Apply something obvious to the 1st picture, e.g. "colorize" filter
  5. Switch back to the "lighttable", select it and press Ctrl+c
  6. Select 2nd, non-edited photo and press Ctrl+v

Observed result

2nd photo stays the same.

Expected result

Settings are copied from 1st to the 2nd photo and changes are reflected in the thumbnail.

github-actions[bot] commented 1 year ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

savchenko commented 1 year ago

@github-actions, reopen.

github-actions[bot] commented 1 year ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

savchenko commented 1 year ago

v4.4.2 -- only partial set of settings is copied using Ctrl+C and Ctrl+V.

Example:

  1. Photo "A" has white balance disabled. Select it and copy settings.
  2. Select photo "B" and press Ctrl+V -- default white balance stays enabled.
parafin commented 1 year ago

It’s not a bug, white balance isn’t copied by default, you must use selective copy-paste instead.