darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.8k stars 1.14k forks source link

Missing application icon after launching #13946

Closed bremner closed 1 year ago

bremner commented 1 year ago

A Debian user reported (and I confirmed in a fresh Bookworm VM),

Under GNOME (43.3), the Darktable icon is visible when searching for the app,
but once the window is spawned, it is associated with a generic missing icon
(for example in Alt+Tab or the Activities overview).

The associated wmclass is "darktable", which seems fine. Not sure why the icon
disappears.

You can see the unknown icon(s) in two places, in the menu bar, and in the dock (?) activity-bar (?) on the bottom.

I'm not a Gnome user, so I don't have any sensible ideas what is going on here. It doesn't seem like something specific to Debian, but I guess you never know.

Nilvus commented 1 year ago

I use Gnome 43.3 (with Debian Sid) as well as, at least one of main developer here, and never had such issue. I can see darktable icon on all parts of Gnome (menu bar, dock, activity, etc.) and use darktable and Gnome since some years now without any issue. Probably something broken on its side. As this is probably not directly darktable code issue, help would be better for him on discuss.pixls.us forum as this place is for things related to darktable code.

You didn't precise which darktable version and how he installed darktable. If darktable is from Debian repository, maybe it's a package issue and so should be seen with Debian package tracker. I use master and compile darktable myself, so don't have darktable package from Debian repository.

bremner commented 1 year ago

Nicolas Auffray @.***> writes:

You didn't precise which darktable version and how he installed darktable. If darktable is from Debian repository, maybe it's a package issue and so should be seen with Debian package tracker. I use master and compile darktable myself, so don't have darktable package from Debian repository.

This is version 4.2.1-3 (where the -3 is the Debian part).

It is tracked in the Debian bug tracker at

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033001

As the Debian maintainer I'm looking for help in resolving this problem. Suggestions for what specific kind of packaging problem might result in this would be welcome.

kmilos commented 1 year ago

Could this perhaps be related to https://github.com/darktable-org/darktable/pull/13193?

Nilvus commented 1 year ago

I don't know. Did you test Open Build Service package, that darktable team propose on its install page, if you have same issue? It's a deb package too. See on install page, in darktable.org website to test it.

@TurboGit: any more idea on that one?

Nilvus commented 1 year ago

Just tested to install darktable 4.2.1-3 package from Debian Sid repository and I have the icon on my side. I even make sure on testing to:

bremner commented 1 year ago

I wonder if there is some missing dependency (or files installed some other way), since I do see the missing icon problem installing in a fresh Debian bookworm VM. Another possibility might be some difference of library version between Bookworm (i.e. current testing) and Sid.

TurboGit commented 1 year ago

That's strange. I have the icon on my dev machine, but let's forget about this one... On another machine Debian/testing I'm installing using standard apt. The icon is there, and this is handled by the standard:

/usr/share/applications/org.darktable.darktable.desktop

Do you have this file installed?

You should have it as it is part of the main package:

$ apt-file search org.darktable.darktable.desktop
darktable: /usr/share/applications/org.darktable.darktable.desktop

Have you installed some flatpak on this machine? Maybe this has messed something....

bremner commented 1 year ago

@TurboGit Yes, I have the file /usr/share/applications/org.darktable.darktable.desktop. The machine is a freshly installed VM, with darktable the only thing installed on top of a basic gnome install. The odd thing is that the icon does show up when searching in activities, just not anywhere else.

bremner commented 1 year ago

BTW, I noticed the problem only occurs in a Wayland, so that may explain why some of you don't see it.

victoryforce commented 1 year ago

BTW, I noticed the problem only occurs in a Wayland, so that may explain why some of you don't see it.

Isn't this an indication that the bug is actually in Wayland and not in darktable?

Nilvus commented 1 year ago

Wayland issue indeed. I use X11, @TurboGit also.And we both have the icon.

bremner commented 1 year ago

@victoryforce It could also be the way darktable is using wayland. It's not like this happens for all applications in GNOME/wayland.

victoryforce commented 1 year ago

@victoryforce It could also be the way darktable is using wayland. It's not like this happens for all applications in GNOME/wayland.

Would you be able to see what the wmclass is for the darktable window and see if adding this name to StartupWMClass= in the darktable desktop file solves the problem?

bremner commented 1 year ago

The wmclass is "darktable" and adding StartupWMClass=darktable at the end of the .desktop file seems to fix it.

victoryforce commented 1 year ago

@bremner Thanks for checking! So I will add this fix to the darktable desktop file.