search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.58k stars 1.13k forks source link

Orientation module not working after crop #14788

Open ActarusLeGrand opened 1 year ago

ActarusLeGrand commented 1 year ago

Describe the bug

4.4.0

After doing a crop on a picture. The flip horizontally work great. The flip vertically,, rotate clockwise, rotate counterclockwise, is not keeping the crop in place.

Steps to reproduce

Do a crop on a picture.

The flip vertically,, rotate clockwise, rotate counterclockwise, is not keeping the crop in place.

Expected behavior

Rotate will keeping the crop in place.

Logfile | Screenshot | Screencast

No response

Commit

No response image_2023-06-27_084530083

2023-06-27_7-45-09 2023-06-27_7-45-29 2023-06-27_7-45-37

2023-06-27_7-46-19 2023-06-27_7-45-50

Where did you install darktable from?

darktable.org

darktable version

4.4.0

What OS are you using?

Windows

What is the version of your OS?

10

Describe your system?

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

jenshannoschwalm commented 1 year ago

You had opened a very similar issue a month ago, it's not concidered to be "nice" to do :-)

All devs read these issues and

  1. if somone thinks it's a genuine bug someone will fix it (often pretty soon)
  2. If it's a feature request find someone being interested to implement as important
  3. if you think it's relevant you might think about joining the project ...
ActarusLeGrand commented 1 year ago

It's a completly different issue. 1 month ago I never used that module. I start using that module after 4.4.0. It took me 1h of my time to make that post.

jenshannoschwalm commented 1 year ago

Excuse me i closed if you think it's a different issue. For me it's pretty much the same...

ActarusLeGrand commented 1 year ago

I forgive you.

jenshannoschwalm commented 1 year ago

Just to explain, both issues are related to the way we handle orientation.

ActarusLeGrand commented 1 year ago

Just to explain, both issues are related to the way we handle orientation.

That sound right.

github-actions[bot] commented 11 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

guigri commented 8 months ago

I scan a lot of slides and then edit them in darktable. The scanned slides all have a black border, so cropping is necessary. Some slides need to be rotated as they were taken on edge. I would like to crop them as long as they have not yet been rotated - it works much better in this order on the monitor. So first crop them while the images fit perfectly on the monitor and then rotate them 90 degrees to their correct orientation. Unfortunately, this is not possible in this order because of this bug.

I'm actually trying to say that this bug is not just a cosmetic flaw. Maybe I can motivate someone to take care of it. If I could, I would vote for it to be fixed. :-) Regardless of this - please don't get me wrong - it's a bit of a pity that with a tool with such professional standards, not even cutting and rotating work properly together. :-)

ptilopteri commented 8 months ago

why don't you make styles for cropping based on image orientation?

Niklas-Zeidler commented 7 months ago

same problem as guigri, I perceive this also as a bug btw.. My workaround for now: have one style for the slides / negatives I'm scanning (e.g. HP5+ ) which does NOT include orientation or crop and have another two styles which include the orientation and the applicable crops for both landscape and portrait orientation. That way I can apply the crop style first and afterwards process all scans the same way. Hope that helps @guigri

github-actions[bot] commented 5 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

ralfbrown commented 3 months ago

The underlying issue is that the crop module's parameters are merely what percentage to remove from each side of the image it is given, followed by forcing the crop back to the specified aspect ratio if not "freehand". But it has no knowledge of rotation applied by the orientation module...

You can work around this by making a custom module order which puts orientation after crop.

github-actions[bot] commented 1 month ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.