darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.66k stars 1.13k forks source link

Darktable nightly build 20231004 - crop factor missing in db #15366

Closed smartintec closed 1 year ago

smartintec commented 1 year ago

Describe the bug

The db created with Darktable nightly build 20231004 for Windows "4.5.0+790~gddc2a5ba2e" doesn't contain any crop factor information. Seems like it got lost somewhere when splitting up table images to cameras and lens tables.

Steps to reproduce

Download and install Darktable nightly build 20231004 for Windows. Run it on machine with existing 4.4.2 stable ( I use a VM for that) Database from 4.4.2 will be converted. Import images in CR3 format from a "Canon EOS M6 Mark II" with a Sigma 16mm F1.4 EF-M lens.

The image information pane shows "focal length" and "35mm equiv" both 16 mm and crop factor 0.0!

It also recognizes the 16 mm Sigma Lens being a 56 mm Sigma Lens - but that's another issue. The same cropfactor issue is with all other lenses and camera combinations.

In the library.db I couldn't find the "crop" field in the tables anymore. And I think that's the reason.

Expected behavior

The image information pane should show "focal length"=16 and "35mm equiv"=25.6 mm and crop factor 1.6

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you install darktable from?

GitHub nightly

darktable version

4.5.0+790~gddc2a5ba2e

What OS are you using?

Windows

What is the version of your OS?

Windows 10

Describe your system?

No response

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

smartintec commented 1 year ago

Oh no, crop column is there in the db. I have overseen it! My bad!!! It's 0 - but that's a total different issue. So the db looks fine! I will close this one. Sorry!!