search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.65k stars 1.13k forks source link

Dji Mavic 3 Pro Raw images can not be loaded #15596

Open freakndenial opened 11 months ago

freakndenial commented 11 months ago

Describe the bug

I tried to edit raw shots from my DJI Mavic 3 Pro. No shot from the 3 lenses can be opened in the darkroom view. The thumbnails are displayed correctly though.

Steps to reproduce

Import .dng files Try to open the images

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you install darktable from?

darktable.org

darktable version

4.4.2

What OS are you using?

Mac

What is the version of your OS?

MacOS Sonoma 14.1

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

kmilos commented 11 months ago

Are you able to share a sample please, maybe for each of the 3 lenses? (via some cloud service for example)

freakndenial commented 11 months ago

Sure, here are shots with the 3 different lenses:

kmilos commented 11 months ago

Thanks for the samples. Would you mind uploading to https://raw.pixls.us/ as well please?

ERROR: [rawspeed] C:/msys64/home/kmilos/rawspeed/src/librawspeed/decompressors/AbstractDngDecompre
ssor.cpp:225: void rawspeed::AbstractDngDecompressor::decompress() const: Too many errors encountere
d. Giving up. First Error:
C:/msys64/home/kmilos/rawspeed/src/librawspeed/decompressors/LJpegDecoder.cpp:97: virtual void raw
speed::LJpegDecoder::decodeScan(): Unsupported predictor mode: 6

DJI started using lossless compression in their recent models/firmware. It is a CinemaDNG-like scheme that is unfortunately not yet supported by rawspeed.

freakndenial commented 11 months ago

Thank you for the quick analysis. I'll take some better lit shots and upload them to raw.pixls.us

AlanzFPV123 commented 10 months ago

I'm having the same issue. Here's a link to a drive folder with 3 dng, jpg, and xmp files if that helps. https://drive.google.com/drive/folders/1ecUwuwdTjJGDlNCh9qjLjwrEtBCEQDOf?usp=sharing

They are 3 captures of the same scene with each of the 3 cameras on the Mavic 3 Pro Cine. Lighting may not be optimal but its all I have at the moment. Willing to help. I have already uploaded to rawpixl.us with camera info from DJI specs page.

AlanzFPV123 commented 10 months ago

Update: I received a message on the Mavic support forum from a user who is able to open OOC .dng files straight from his Mavic 3 Pro. He is on version 4.4.2, same as I am. Why would that be?

Also - looks like RawTherapee has it working already

kmilos commented 10 months ago

Why would that be?

Uncompressed mode somehow.

AlanzFPV123 commented 10 months ago

I don't know how - i simply copied the files straight form the aircraft hard drive to my external drive, then imported to Darktable. So can you tell me - this issue appears to be open still - is version 4.4.2 supposed to have full support for dng files from the Mavic 3 pro? I didn't see the drone listed under supported cameras. Last - I believe the Mavic 3 Cine (an older version of the drone) had a different camera setup. I'll check with the guy in the Mavic forum to see which drone he has, but again, none of them are listed as supported.

kmilos commented 10 months ago

We generally don't list devices that output DNG, as the list would be unwieldy (think about all the smartphone models).

Most of the time DNG just works (check some other DJI model samples from raw.pixls.us). It's just that some vendors (please see release notes) sometimes use slightly different/customized compression schemes (to the most common one that Adobe usually does) that need to be implemented additionally. Turns out DJI started doing it w/ the Mavic 3 Pro, whereas other/older models output uncompressed.

kmilos commented 10 months ago

Btw, one can always try re-compressing the OOC DNG w/ the Adobe DNG Converter in the meantime.

AlanzFPV123 commented 10 months ago

Thank you for explaining this. Makes sense to me now. And thanks for all you do with this software.

AlanzFPV123 commented 10 months ago

I spoke with the guy in the Mavic forum and relayed your comment re compression. His experience is that he can open files from the Mavic 3 Pro with Darktable and other software.

Quote: “Well, I have no problem opening .dng files from Mavic 3 Pro with the 8 years old Adobe Camera Raw 9.11, which was released in 2015. I have tried opening the same files in several other raw converters, some older, some more recent. No problem. I think your information is not correct.”

victoryforce commented 10 months ago

I spoke with the guy in the Mavic forum and relayed your comment re compression. His experience is that he can open files from the Mavic 3 Pro with Darktable and other software.

As was written above, it may be a change in coding (compression) in new firmware or model modifications.

Quote: “Well, I have no problem opening .dng files from Mavic 3 Pro with the 8 years old Adobe Camera Raw 9.11, which was released in 2015. I have tried opening the same files in several other raw converters, some older, some more recent. No problem.

But Darktable has a problem opening your samples (both 4.4.2 and the current development snapshot). If that guy has no problems with Darktable, then his files are different. Or maybe he didn't claim that his files could be opened by Darktable, since the quote doesn't mention it?

The guy is right that many raw processors open such files. Your samples are easily opened by ART and Rawtherapee. But in these programs, the code taken from dcraw and the Libraw library, respectively, are responsible for reading raw files, if I'm not mistaken. We use Rawspeed and it does not support these files, unfortunately.

I think your information is not correct.”

It is not clear from the quote what information is being discussed.

kmilos commented 10 months ago

@AlanzFPV123 Please provide the Mavic 3 Pro sample that opens w/ dt 4.4.2

AlanzFPV123 commented 10 months ago

I asked the guy to upload some files and gave him the link. He did say that 4.4.2 opens his Mavic 3 pro dng files and posted a screenshot. I could not download it for some reason but I took a screenshot of the data panel if it helps. Hopefully he will upload files.

AlanzFPV123 commented 10 months ago

image

kmilos commented 10 months ago

FC2204 is not Mavic 3 Pro AFAICT, but e.g. DJI Mavic 2 Zoom. The shot is from 2019, so your "expert" must be in a posession of a time machine as well.

AlanzFPV123 commented 10 months ago

Ok. That makes sense to me - I had thought his drone was older than mine and said so, to which he replied that his Mavic 3 pro files also work. I think this guy may not be credible, and apologize for this wild goose chase. If he uploads some files you’ll be ahead of the game. If he doesn’t you have mine. Let me know if you need any more files from me with different exposure or ?? Happy to help any way I can.

Sent from Gmail Mobile

On Sat, Nov 18, 2023 at 12:00 PM Miloš Komarčević @.***> wrote:

FC2204 is not Mavic 3 Pro AFAICT, but e.g. DJI Mavic 2 Zoom.

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/15596#issuecomment-1817621045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWI3ZS4NJ6U753ML54HNESDYFEHWRAVCNFSM6AAAAAA7BZCZKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGYZDCMBUGU . You are receiving this because you were mentioned.Message ID: @.***>

kmilos commented 10 months ago

Finally, please keep in mind GitHub issues is not a free flow user discussion forum but a place to focus on factual problems in relation to dt development. You have discuss.pixls.us for anything else.