Rotation leaves parts of pictures blank

[SteveMan67]

Describe the bug

When adjusting the Rotate and Perspective Rotation module, If adjusted to quickly, the program leaves this triangle of black at the edge of the picture, and it does not fix itself without setting the rotation back to zero again.

As you can see in the top right edge of this photo, it leaves just enough space to be noticeable, sometimes more.

Steps to reproduce

1. Open Darkroom
2. Go to the rotate and perspective module and adjust the rotation

Expected behavior

crop as it is rotating to eliminate blank space.

Logfile | Screenshot | Screencast

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.4.2

What OS are you using?

Windows

What is the version of your OS?

Windows 10

Describe your system?

Processer Intel(R) Xeon(R) CPU E31225 @ 3.10GHz 3.10 GHz Installed RAM 20.0 GB System Type 64-bit operating system, x64-based processor

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[wpferguson]

What do you have automatic cropping set to?

[elstoc]

It doesn't matter -- in some cases (at least in 4.4.2) it fails to crop properly regardless of the setting. This may have been fixed in master but I haven't been able to check since I haven't found a consistent reproducer.

[wpferguson]

I may have seen this happen a long time ago, but I haven't seen it in the last couple of years and I use it a lot (several hundred images per week) and I'm OCD about verticals being vertical. I'll see if I can reproduce on windows.

[wpferguson]

Tried on windows with and without lens correction, in case there was an interaction. Unable to reproduce. I don't have opencl on the VM, so it was a CPU only test.

[jenshannoschwalm]

There were interpolators fixes done in master. This could also be affected.

[elstoc]

For me it sometimes just looks like it's ignored the contents of the combobox and chosen not to crop anyway.

[jenshannoschwalm]

For me it sometimes just looks like it's ignored the contents of the combobox

I have not seen that but it would pinpoint to the pixelpipe. I confess i have used that module via loupedeck in 99% of the use cases for rotation so no open module for most cases ...

[github-actions[bot]]

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

[ralfbrown]

I've seen it on occasion when doing fast repeated small rotations via keyboard shortcut. The most recent time this occurred, I was able to fix it by switching automatic cropping to "largest area" and back to "original format". So it's probably a race condition.

[jenshannoschwalm]

I've seen it on occasion when doing fast repeated small rotations via keyboard shortcut.

Yes i have also seen that but only while using keyboard shortcuts. Don't understand ...

[jenshannoschwalm]

@ralfbrown can you confirm that while using shortcuts with key combinations like ctrl_r there is some issue dependency on the Ctrl key still being down?

[elstoc]

I've seen it when going back to earlier points in the history stack as well.

[ralfbrown]

I use Alt-[ and Alt-] as my rotation shortcuts. I do usually leave Alt pressed when doing rotations until I'm sure I'm done.

[Donatzsky]

Just had it happen to me. Used right-click drag to straighten a line, used ctrl-z to undo. When exporting it also looks like that.

Rotate and perspective is still active after undoing:

History stack: The local contrast was just to see if doing something else would fix it.

It's almost as if ctrl-z only undoes the crop, not the rotate.

Not using OpenCL.