darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.69k stars 1.14k forks source link

RGB Curves question/issue #15970

Closed ericlief closed 9 months ago

ericlief commented 9 months ago

Describe the bug

When I put a node on the curve and pull down the part of the curve above the node moves up, like spaghetti. Screenshot 2023-12-26 at 11 22 40 PM

Steps to reproduce

Open curves

Expected behavior

The node should fix the part outside of the modified section

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.6.0

What OS are you using?

Mac

What is the version of your OS?

13.6.1

Describe your system?

Macbook air, M1 (2019), 16GB

Are you using OpenCL GPU in darktable?

No

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

HSUfineprint commented 9 months ago

That's what a curve works. You can try the curve function in photoshop, it works the same. In darktable, you can choose centripetal spline to avoid that.

MStraeten commented 9 months ago

not a bug, but a feature.

ericlief commented 9 months ago

Thank you. I just tried the curves in Lightroom and Gimp and they don't work the same way. I no longer have access to Photoshop, so I can't test this. The curve extends only within the nodes. In DT, the other modes mentioned or a little better, but there is still movement. I'm just curious what the motivation is for having values outside of the range we want to modify change?

MStraeten commented 9 months ago

nonlinear curves results in nonlinear change of colors - also known as banding. Usually not intended… you may consult https://darktable-org.github.io/dtdocs/en/darkroom/processing-modules/curves/ for explanations of the modes