search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.91k stars 1.15k forks source link

Lr sidecar files import: use of deprecated module crop and rotate leads to wrong display #16200

Open manu-p opened 10 months ago

manu-p commented 10 months ago

Describe the bug

Hi,

When importing an Lr edited TIFF file as described here, it occurs that the deprecated module "crop and rotate" may be used which leads to some wrong display in the darkroom.

The following message is then displayed in the module itself:

this module is deprecated. please use the crop, orientation and/or rotate and perspective modules instead.

And when you turn off crop and rotate, you loose the following modules in the pipe...

This is an example of Lr edited TIFF file : https://www.swisstransfer.com/d/5db547a7-3e27-48f9-b6b0-992b7e579702 Corresponding XMP file : https://www.swisstransfer.com/d/6578b93a-b1e0-4f26-9f5d-0aa63661e955

Steps to reproduce

  1. import an image previously edited with Lr with its XMP sidecar file, where some cropping and/or rotation had been done
  2. switch to the darkroom to see the wrong display
  3. open the crop and rotate module to see the message

Expected behavior

dt don't use deprecated crop and rotate module

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.6

What OS are you using?

Windows

What is the version of your OS?

10

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

ralfbrown commented 10 months ago

The lightroom sidecar conversion is really old code. Obviosuly nobody has touched it since c&r was deprecated a couple of years ago....

manu-p commented 10 months ago

Sure!

So, maybe this code should be reviewed in some way. The other modules:

are not yet deprecated...

ptilopteri commented 10 months ago

you are volunteering to help with this?

darktable is free and open source software. if one itches, they are perfectly capable of scratching and everyone else benefits. if no itch, scratching seldom happens on it's own.

manu-p commented 10 months ago

I'm OK to help, although in this case I'm not directly affected, but I'm relaying a French dt user who doesn't feel like being able to declare an issue, like a very large number. As you can see, I'm already helping.

I'm not a dev, so I won't help on this side I'm afraid. But maybe someone will ask me for data or informations I could answer?

manu-p commented 10 months ago

I add I never used Lr, but I reckon it's important to help Lr users to move to dt.

manu-p commented 10 months ago

I understand. Reminds me in some way of Open/LibreOffice vs MS Office before MS went to XML and the users not willing to leave the second as long as the first is not able to edit MS office files (almost) correctly.

Does the code you're talking about needs to be in dt? Can't it be an external dt app? Can't it be designed/developed for version(s) of Lr up to A.b (or whatever Adobe name it) so that users are informed and may contribute by providing xmp files when their need is so? A bit like for new RAW formats or lenses and lensfun.

Just ideas, thanks for your previous replies.

manu-p commented 10 months ago

That makes sense, I do agree with your point of view @gi-man. That's what I did as I left years ago bibble when it became After Shor Pro.

I don't want to further mess anyone here, I know most of you have many other things to sort out, of much more interest than this topic.

TurboGit commented 10 months ago

When importing an Lr edited TIFF file as described here, it occurs that the deprecated module "crop and rotate" may be used which leads to some wrong display in the darkroom.

Clearly the Lr XMP is only for the importing RAW files and the .xmp is meant to be applied automatically in this case.

TurboGit commented 10 months ago

A side note, I'm the author of the Lr migration support. Since a long time I have moved away from Lr and do not have a huge motivation to support this especially since I cannot experiment as I don't have Lr anymore. But if someone come with some fixes / enhancement with the RAW, the Lr XMP and the look it should have in Lr I'll be happy to review and integrate patches.

github-actions[bot] commented 8 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

lutorm commented 4 months ago

I'm trying to migrate from LR to dt, too, and I'm also having a cropping problem. The cropping info in the LR XMP appears to be imported correctly into the crop and rotate module, and I'm seeing the correct crop in dt. However, if I open the settings for that module after importing, I see the deprecation message manu-p mentioned above, and at the same time the crop gets reset to some seemingly arbitrary square-aspect-ratio crop that matches neither the width or height of the correct crop. Any idea what goes on here? Hitting Ctrl-z to attempt to undo that change doesn't work, nothing happens. Also, it doesn't matter if the imported file is a RAW or jpeg file, the same thing happens.

github-actions[bot] commented 2 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.