darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.59k stars 1.13k forks source link

Deactivate initial rating when ignore EXIF rating is deselected (import module) #16262

Open l0f4r0 opened 7 months ago

l0f4r0 commented 7 months ago

Is your feature request related to a problem? Please describe. In import module, initial rating while retrieving EXIF rating seems to be contradictory to me.

Describe the solution you'd like I think initial rating should be deactivated when EXIF rating ignorance is not checked.

wpferguson commented 7 months ago

I rate some of my images in camera for quick retrieval when I import into darktable. The rest I want imported at the default rating. I usually shoot 1000+ images at a time, so rating them all in camera isn't feasible.

l0f4r0 commented 7 months ago

@wpferguson: ok you mean there could be 2 different actions at the same time when deactivating "EXIF notation ignorance":

Correct?

wpferguson commented 7 months ago

Correct?

It appears that I misspoke. I just double checked my settings and the on import rating is set to 1 star. All my images import with 0 stars unless I change the rating, so if you don't rate the image in camera then the EXIF default rating in the camera gets applied (in my case no stars).

You're understanding of how it works is correct. Sorry for the noise.

l0f4r0 commented 7 months ago

I'm a little confused now...

Are you telling me that your camera is configured to set a 0 star rating by default so in Darktable 0 star is applied to all your pictures (except those with a specific rating in your camera => correct star is retrieved as well) when you deactivate "EXIF rating ignorance" BUT have any setting applied in "initial rating"? In other words, no matter the "initial rating" parameter in Darktable when "EXIF rating ignorance" is unchecked...

wpferguson commented 7 months ago

your camera is configured to set a 0 star rating by default so in Darktable 0 star is applied to all your pictures (except those with a specific rating in your camera

yes

when you deactivate "EXIF rating ignorance"

the setting that darktable is set to (in my case 1 star) is applied.

l0f4r0 commented 7 months ago

I did some testing from my side as well.

github-actions[bot] commented 4 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.