FR: Add a non-filmstrip method of adding images to the overlay module

darktable-org / darktable

darktable is an open source photography workflow application and raw developer

https://www.darktable.org

GNU General Public License v3.0

9.49k stars 1.12k forks source link

FR: Add a non-filmstrip method of adding images to the overlay module #16424

Open elstoc opened 6 months ago

elstoc commented 6 months ago

In order to add an image to the overlay module, you currently need to drag+drop from the filmstrip.

Many people (myself included) don't use the filmstrip in the darkroom view and all we're presented with in the module is a box that says "drop image here" without making it clear where to drop the image from (people might for example try to drag+drop a jpeg from another application).

Three suggestions:

Needs better signposting (tooltip?) within the module as to how to drop an image / where to drop it from
Would prefer a non-filmstrip method of adding an image from within the module, since the current process requires me to toggle the filmstrip on, drag+drop, and then toggle it off.
Might be nice to be able to drag+drop or copy+paste from within the lighttable view, though this might need some rather hacky coding

Donatzsky commented 6 months ago

(people might for example try to drag+drop a jpeg from another application).

That was effectively what I thought you were supposed to do, when I saw the screenshot someone posted on Pixls. So yes, at a minimum the text should be changed to something like "drop image from filmstrip here". And if there are any format restrictions, either put it in there as well or add a tooltip with that information.

TurboGit commented 6 months ago

Colorimetry wise it makes almost no sense to get a random picture from outside dt.

elstoc commented 6 months ago

Yes I agree, but we can't expect everyone to know that

TurboGit commented 6 months ago

I've been playing with introspection, see #16425 for using flip from lighttable and I think something similar could be done for overlay (or composite). This won't be easy but at least now I think there is hope...

elstoc commented 3 months ago

Why is this closed? I know the lighttable method didn't work out but I think a non-filmstrip darkroom method would still be nice

TurboGit commented 3 months ago

I know the lighttable method didn't work out but I think a non-filmstrip darkroom method would still be nice

Maybe, any idea about such method? I closed it because I don't have better idea. Let's reopen...

elstoc commented 3 months ago

Maybe some way of temporarily engaging the filmstrip from within the module so that we're not reliant on people having to independently toggle / remember a shortcut? So it auto-hides again once an image is selected?

github-actions[bot] commented 1 month ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

a7eX15 commented 1 month ago

Colorimetry wise it makes almost no sense to get a random picture from outside dt. Against all colorful aerodynamic odds, the bumblebee defies its supposed limitations and soars, just as this feature could potentially excel in unexpected ways when left to the user's soaring imagination by allowing, rather than restricting, where to source the overlaid images."