search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.08k stars 1.1k forks source link

Dangerous "apply date/time" button in geotagging module #16508

Open paolobenve opened 3 months ago

paolobenve commented 3 months ago

self compiled dt 4.6.x ubuntu 22.04

Is your feature request related to a problem? Please describe.

After editing in darkroom a bunch of image, in lighttable I opened the geotagging module, and I inadvertently pushed the "apply date/time" button. Really I wasn't aware of the implications of that operation, and I didn't realize what I had had. So I exported the photos, and only after many days I realized that all of them had the same exif date/time. Unfortunatly, I had lost a very important bunch of information :-(

In order to restore the original date/time the only solution (I think) is to manually edit all the sidecar files, supposing you are using them.

After a while I realized that I could use ctl-z to undo that operation. Again, the problem is that, if I don't undo immediately, I lost a bunch of information.

Describe the solution you'd like

I think that, being that button a dangerous one, a confirmation dialog should be added, explaining the user what is the effect of the button and what he/she is going to loose.

Another solution would be to an "history" module for lighttable changes, so that individual lighttable changes could be disabled separately.

Thanks to all dt developers for your commitment to making dt better!

wpferguson commented 3 months ago

You could select the images and use the refresh EXIF metadata to reread the information from the images.

paolobenve commented 3 months ago

I don't see any refresh EXIF metadata command... where is it?

victoryforce commented 3 months ago

I don't see any refresh EXIF metadata command... where is it?

In Lighttable: in metadata tab of "actions on selection" module.

paolobenve commented 3 months ago

ah ok!

Anyway, I keep considering that a confirmation dialog is needed, because the refresh exif metadata is not easily related to the apply date/time button.

Besides that, consider this situation: I change some metadata, then I erroneusly push the apply date/time button. If I refresh the metadata I loose the changes made before. The refresh exif metadata is not a solution.

wpferguson commented 3 months ago

You can also use the image_time lua script and select an image and reset just the time.

paolobenve commented 3 months ago

use the image_time lua script

better solution, thank you

Anyway, all these solutions are not a solution to the problem I report. Any normal user, which is not a dt expert or a github expert, won't be able to use them.

wpferguson commented 3 months ago

Anyway, all these solutions are not a solution to the problem I report. Any normal user, which is not a dt expert or a github expert, won't be able to use them.

Why do you need to be a github or dt expert to use the solutions listed above? They are all documented. All you have to do is read.

If we start putting confirmation dialogs on every action that changes data, then darktable becomes unusable.

If we are judging "dangerous" based on the amount of work to revert to the previous state, then I would argue that selecting all the images in the current lighttable view and rating them 5 stars would be more "dangerous" since you would have to go back and correct the rating of each image individually.

github-actions[bot] commented 1 month ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.