search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.07k stars 1.11k forks source link

Getting strange artifacts when applying certain noise reduction #16634

Open oldblackcrow opened 2 months ago

oldblackcrow commented 2 months ago

Describe the bug

When I apply a noise reduction, like Denoise Profiled, I get strange artifacts as seen in this image. If I turn off the noise reduction filter, the artifact goes away. However, the artifacts do not show up in any exported image.

image

Steps to reproduce

  1. open a RAW image.
  2. apply various noise filters.
  3. depending on something, strange, colorful artifacts appear only within DarkTable.

Expected behavior

Noise reduction should just reduce noise (or not) but should not show artifacts.

Logfile | Screenshot | Screencast

image

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.6.1

What OS are you using?

Windows

What is the version of your OS?

Windows 11 Home Edition

Describe your system?

Laptop with the following: 11th Gen Intel(R) Core(TM) i3-1115G4 @ 3.00GHz 3.00 GHz 20.0 GB (19.7 GB usable) 64-bit operating system, x64-based processor Touch support with 10 touch points

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

oldblackcrow commented 2 months ago

Windows 11 Home Edition Version: 23H2 Build: 22631.3447

jenshannoschwalm commented 2 months ago

We would want the raw and xmp file to investigate.

oldblackcrow commented 2 months ago

I tried sending you the raw file but it is too big... even with zipping it. Do you have another way for me to send it? Thanks!

On Fri, Apr 19, 2024 at 10:18 AM Brian M. Ross @.***> wrote:

Here are the files you requested... however, it's happening on almost all files. I hope this can be resolved, even if it's on my end. Thank you for your help!

On Wed, Apr 17, 2024 at 1:44 PM Hanno Schwalm @.***> wrote:

We would want the raw and xmp file to investigate.

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/16634#issuecomment-2061866202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK2CGVD7CATFGKMBXAJ5AHDY52YIRAVCNFSM6AAAAABGLNVDCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRHA3DMMRQGI . You are receiving this because you authored the thread.Message ID: @.***>

jenshannoschwalm commented 2 months ago

Some file sharing service?

oldblackcrow commented 2 months ago

Okay... sorry about that!

Here's the link to my Google Drive https://drive.google.com/drive/folders/1sz1Z3LNw4YJ_kOmQ13eSJ0XPI7y2m2JE?usp=sharing

Thanks again!

On Sat, Apr 20, 2024 at 12:08 AM Hanno Schwalm @.***> wrote:

Some file sharing service?

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/16634#issuecomment-2067541830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK2CGVB47ZO6TIQJRFKNKKLY6HS5FAVCNFSM6AAAAABGLNVDCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGU2DCOBTGA . You are receiving this because you authored the thread.Message ID: @.***>

jenshannoschwalm commented 2 months ago

Got both files, so you are into astro photos?

Can't reproduce here on master. There is some heavy noise involved and i would say your numerous denoise modules will certainly fight with each other and could possibly not improve output any longer but such artifacts, no.

Can you confirm that the only module involved is "profiled denoise"? If so, what happens if you change internal parameters of algo?

Would you be able to produce a video of your dt window?

ptilopteri commented 2 months ago

I also tried sub image and increased to %400 but only oddity I see is pixelation.

openSUSE Tumbleweed 20240418 dt 4.7.0+981~g63cf4e6d9b

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc

github-actions[bot] commented 2 weeks ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.