darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.88k stars 1.15k forks source link

Reimplement "AI detection of image edges" in color calibration #16730

Open bilddateien opened 6 months ago

bilddateien commented 6 months ago

Is your feature request related to a problem? Please describe.

related to PR #16247 mentioned in release notes: I cannot understand why this is option is removed from darktable since it is my most-used setting.

Describe the solution you'd like

undo that mentioned PR

Additional context

Please see discussion here about my reasons and also find some example files:

          This is sad news ... "AI detection of image edges" has been my preferred setting for my wildlife photos since the introduction of color calibration. I like the golden light at times when the sun is low - this option gave me a "one-click option". When the golden "cast" was too exaggerated, a simple shift of the color temperature slider and I was done.

Originally posted by @bilddateien in https://github.com/darktable-org/darktable/issues/16247#issuecomment-2081164097

Please note that I simply use natural light in my photography and also natural subjects. There is no "exotic" light setup or subject colors to consider. Under these circumstances for my visual perception, this option works to my expectations.

hoerianer commented 5 months ago

I used the choice "Determine from edges" very often and so that very good results. I don't understand why you have removed it now. Why is the reason given that the results were poor? I can not comprehend that. Is there no way to add that again? It would make my work a lot easier for me. Thank you.

github-actions[bot] commented 3 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.