search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.86k stars 1.15k forks source link

Remove Haze does not work for certain images #16746

Open bes1002t opened 6 months ago

bes1002t commented 6 months ago

Describe the bug

When using feature "haze removal" I will see expected changes in most of my images. However in some images nothing happens when I move the slider to the very right side. Also moving it back to the very left side does not have any effect.

For some of the affected images (I know sounds fuzzy, but that's how it is), activating "chromatic abberations" function will fix the haze removal issue and I can then see the effect of "haze removal".

In #2175 this issue is already described but was not reproducable. Hope it will help if I attach one of the affected raws here.

https://drive.google.com/file/d/1Nb413hb8lf5EdHxz-9l2sdvbv7gmcVuo/view?usp=sharing

Note: currently it seems the upload does not work? The automatically inserted link just refers to the ticket itself and not to the file. I will retry tomorrow and provide information via cloud solution in worst case.

Steps to reproduce

  1. open an affected image
  2. activate "haze removal"
  3. nothing happens

Expected behavior

apply the haze removal to the image

Logfile | Screenshot | Screencast

https://drive.google.com/file/d/1YHm4yy3J9eacb5x-70iDxjXMEOdQgv-o/view?usp=sharing

Commit

No response

Where did you obtain darktable from?

distro packaging

darktable version

4.6.1

What OS are you using?

Linux

What is the version of your OS?

Fedora 38

Describe your system?

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

jenshannoschwalm commented 5 months ago

First, i could not reproduce yet - on current master.

hazeremoval is in some ways a bit "difficult", the has-no-effect issue could be related to a number of problems as it a) possibly takes data from the preview pipe and b) there have been some issues with the guided filter that might be fixed in darktable master. To investigate this issue we would require a fresh log while having your issue done by using darktable -d pipe using either current master or 4.8 after that arrives in the repo.

github-actions[bot] commented 3 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

ralfbrown commented 2 weeks ago

@bes1002t If you are able to run one of the available nightly or weekly builds, please test your problematic images with a current development version of darktable. 17650 is likely to have fixed the problem.