search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.78k stars 1.14k forks source link

Inconsistent behavior when removing a shape #16961

Open victoryforce opened 5 months ago

victoryforce commented 5 months ago

Consistency is what the user always expects in any interaction with the program. We offer several interfaces where the user can initiate the creation of shapes (masks). With all the obviousness, the user expects that there is a single process of working with shapes, the behavior of which does not depend on where the creation of the shape is initiated from (the mask manager, the module with its own widgets for creating shapes, the drawn mask interface).

The problem is that such a difference currently exists.

Let's, for example, delete a path by clicking the right button on a path segment. This works if we initiate the path creation by clicking on the widget in retouch module, but does not work if it is initiated from the mask manager module. OK, there is an option in the mask manager to remove the shape via the menu, but that doesn't excuse the different behavior. The user experience should not differ depending on where we initiated the shape creation.

Tested on the current snapshot, although this behavior was seen in 4.6.0 and has probably been there before, if not from the beginning.

wpferguson commented 5 months ago

Masking in most modules (all except retouch?) is taking the result of the module and "laying" it over the previous step and blending it so it occurs after the module performs it's operations. In retouch the mask elements are the module operators, not an extra operation performed after. The retouch module "masks" also perform operations that the normal masks don't (clone, heal, blur).

If anything, I don't think that the retouch module "masks" should show up in mask manager.

github-actions[bot] commented 3 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.