darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.06k stars 1.11k forks source link

Global Color Picker broken in 4.8.0 #17067

Closed apolozanionut closed 14 hours ago

apolozanionut commented 5 days ago

Describe the bug

Just updated to 4.8.0 and the global color picker is acting erratically, sampling points from different parts of the image than the ones selected. I tried restarting the software, reseting the color picker, however no change. It appears to not be consistent, for some images it works properly, for others it's malfunctioning.

Steps to reproduce

  1. Ctrl + Click on Global Color Picker
  2. Left click and drag area of interest
  3. Inspect Waveform view
  4. Discover wrong area of image sampled

Expected behavior

Darktable should sample the area selected in the GUI rectangle drag

Logfile | Screenshot | Screencast

Screenshot 2024-06-28 at 12 12 12 AM Screenshot 2024-06-28 at 12 12 20 AM

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.0

What OS are you using?

Mac

What is the version of your OS?

MacOS Sonoma, 14.5

Describe your system?

Apple Mac Studio M1

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

Apple Studio M1

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

pehar1 commented 5 days ago

Can reproduce with 4.9.0+41~g45d7d3149b but only if the image has been rotated (using orientation -> rotate or rotate and perspective -> rotation). The live sample shown in the color picker is correct, the data shown in scopes (only checked waveform) is wrong.

ralfbrown commented 4 days ago

I would have said this sounds related to #17006, but given that 4.9.0+41 already includes that PR, I guess not.

jenshannoschwalm commented 4 days ago

confirmed, understood, fix following.

jenshannoschwalm commented 4 days ago

@apolozanionut you might want to test the pr if you compile dt yourself ...