search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.63k stars 1.13k forks source link

Nikon Z6III #17075

Open rick05chap opened 3 months ago

rick05chap commented 3 months ago

Uploaded the first image. Will upload the remaining images in the next couple of minutes.

Nikon Z6 _3 Lossless compressed FX.NEF Nikon Z6 _3 High Efficiency 1_1.NEF Nikon Z6 _3 High Efficiency 16_9.NEF Nikon Z6 _3 High Efficiency DX.NEF Nikon Z6 _3 High Efficiency FX.NEF Nikon Z6 _3 High Efficiency Star 1_1.NEF Nikon Z6 _3 High Efficiency Star 16_9.NEF Nikon Z6 _3 High Efficiency Star DX.NEF Nikon Z6 _3 High Efficiency Star FX.NEF Nikon Z6 _3 Lossless compressed 1_1.NEF Nikon Z6 _3 Lossless compressed 16_9.NEF Nikon Z6 _3 Lossless compressed DX.NEF

LebedevRI commented 3 months ago

Lovely. @rick05chap thank you for contributing full sample set!

rick05chap commented 3 months ago

Roman,Please let me know if there is anything else I can submit that would be of use.Rick ChapmanOn Jun 29, 2024, at 5:07 PM, Roman Lebedev @.***> wrote: Lovely. @rick05chap thank you for contributing full sample set!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

kmilos commented 3 months ago

Please feel free to test the linked PR (lossless only), feedback is welcome.

Dantoes commented 1 month ago

Hi, I was wondering if there are any updates on this. I'd like to be able to edit the photos I've taken with this camera. Thanks!

igillingham commented 1 month ago

Hello - just checking to see if there's any progress for Z 6 3 support? I love Darktable but have not been able to use it since acquiring my new camera. I am a software developer so could possibly help out if needed. I have tested the branch https://github.com/darktable-org/rawspeed/pull/739, but the new build of Darktable still won't open my NEF files (14 bit lossless).

kmilos commented 1 month ago

@igillingham You removed the initial failed imports first, or tried this?

Dantoes commented 1 week ago

I added your changes to /usr/share/darktable/rawspeed/cameras.xml, started darktable 4.8.1, removed the film roll containing the Z6_3 images, deleted all *.xmp files in that directory and then re-imported the directory. When I try to open a photo it fails with the following log messages:

    51,3639 [rawspeed] (DSC_2878.NEF) rawspeed::RawImage rawspeed::RawDecoder::decodeRaw(), line 338: rawspeed::Buffer::size_type rawspeed::ByteStream::check(rawspeed::Buffer::size_type) const, line 64: Out of bounds access in ByteStream
    51,3639 [libraw_open] extensions whitelist: `cr3'
    51,3640 [qoi_open] no proper file header in <path>/DSC_2878.NEF
    51,3652 [temperature] failed to read camera white balance information from `DSC_2878.NEF'!
    51,3652 [temperature] failed to read camera white balance information from `DSC_2878.NEF'!
    51,5982 [temperature] failed to read camera white balance information from `DSC_2878.NEF'!
    51,5982 [temperature] `Nikon Z6_3' color matrix not found for image
    51,5983 [temperature] failed to read camera white balance information from `DSC_2878.NEF'!

Do I have to compile the develop-branch with your changes applied? I figured it shouldn't be necessary, since it's a just config file change.

kmilos commented 1 week ago

Do I have to compile the develop-branch with your changes applied? I figured it shouldn't be necessary, since it's a just config file change.

Usually not necessary. Are you sure you're using lossless and not HE? If this happens on lossless, this could indicate that either the file is corrupt, or there were some changes to the format that require code changes. Unfortunately I can't test as raw.pixls.us is down...

Dantoes commented 1 week ago

You are right, the images are HE-Star-compressed. I thought I had changed the setting, but it looks like I didn’t. Thank you for the hint!

Fade78 commented 2 days ago

You are right, the images are HE-Star-compressed. I thought I had changed the setting, but it looks like I didn’t. Thank you for the hint!

Do you mean the is a way to open the uncompressed raws from the Z6iii with Darktable 4.8.1?

I don't understand what are the actual changes to make to do so. What are the change to add to cameras.xml?

kmilos commented 2 days ago

Do you mean the is a way to open the uncompressed raws from the Z6iii with Darktable 4.8.1?

AFAIK there is no uncompressed option. But you should be able to open the traditional lossless compressed (as opposed to unsupported HE compressed).

What are the change to add to cameras.xml?

They are shown in the linked PR. Or just download and replace the entire cameras.xml from there.

Fade78 commented 2 days ago

Thanks, i'll take a look this evening. I meant lossless compression so it's perfect.

Fade78 commented 2 days ago

It works! I modified /var/lib/flatpak/app/org.darktable.Darktable/x86_64/stable/(some uuid here)/files/share/darktable/rawspeed/cameras.xml

Fade78 commented 2 days ago

So the "Lens correction" module display an error (body not found) - I replaced with Z6 II and it applied some correction, I hope this is not to far from truth. That's very minor, I'm very happy to be able to use my RAWs before the official release.

kmilos commented 2 days ago

So the "Lens correction" module display an error (body not found)

That is down to the lensfun database and out of scope for dt. (If you really want to, you can make a similar addition there manually btw.)

Fade78 commented 2 days ago

It works also. The file is /var/lib/flatpak/app/org.darktable.Darktable/x86_64/stable/(some uuid)/files/share/lensfun/version_1/mil-nikon.xml

Today feels like Christmas.