search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.49k stars 1.12k forks source link

Rejecting an image in filtered full screen culling mode does not remove it from culling overview #17150

Closed gerritsangel closed 1 month ago

gerritsangel commented 1 month ago

Describe the bug

When rejecting an image in full screen culling mode, it is not removed from the culling overview, even though the image is removed when being in the culling overview

Steps to reproduce

  1. Select "All except rejected" in the quick filter
  2. Select multiple images, go to dynamic culling mode
  3. Then open a image in full screen (from the culling mode) via F
  4. Reject the image via R
  5. Jump back to culling overview via Escape
  6. The image is still in the culling overview
  7. Then, in the culling overview, reject an image by hovering over it and press R
  8. The image is directly removed (and the previous one as well, because the overview refreshes completely)
  9. Sometimes, when there are a lot of images open in the culling overview (but not always), scrolling the mousewheel also refreshes the filter and removes the image from the overview

Expected behavior

The image should be removed from the overview because the filter is set to "All except rejected", and the behaviour should be the same as rejecting from the overview

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.0

What OS are you using?

Windows

What is the version of your OS?

Windows 11 Home

Describe your system?

No response

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

wpferguson commented 1 month ago

@Solarer does #13278 handle this or should it remain separate?

AlicVB commented 1 month ago

My bad, I've got the wrong issue number. So forgot what I've said before... I reopen the issue which is not fixed at all.

That said I don't think that @Solarer works fix it. For me it looks like a missing refresh somewhere...

Solarer commented 1 month ago

That said I don't think that @Solarer works fix it. For me it looks like a missing refresh somewhere...

Correct