darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.55k stars 1.13k forks source link

Image appears too warmth when using some modules (ToneEQ or diffuse/sharpen or ....) #17151

Open atomikdg opened 2 months ago

atomikdg commented 2 months ago

Describe the bug

I saw this bug when switching between local contrast and local contrast fast (diffuse/sharpen). This seems not related to a particular operation using module. I had it with color balance rgb on/off (when off, if I reset the module the yellow/warmth colors disappears). Also when zooming, the colors came back to normal.

If you need more information let me know.

Version: last 4.8.x ( 18026f9f50e97199a719627b0d61532e88aa4b23 ) but don't know when this bug came in.

Steps to reproduce

See videos here : https://nx22856.your-storageshare.de/s/aNgjDZSmcxNkzyo

Expected behavior

Image should be with "correct" colors

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

4.8.x 18026f9f50e97199a719627b0d61532e88aa4b23

What OS are you using?

Linux

What is the version of your OS?

Opensuse tumbleweed

Describe your system?

Same behavior wayland and X11 32 Gb ram 8GB video nvidia

GTK+: libgtk-3.so.0 => /lib64/libgtk-3.so.0 (0x00007fb0e7c00000) libcolord-gtk.so.1 => /lib64/libcolord-gtk.so.1 (0x00007fb0e83dd000)

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

nvidia 550.100 RTX 3050 8Gb

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

jenshannoschwalm commented 2 months ago

This is a not considered to be a bug I would say. You observe the effect of the very large filter radius.

If you want to avoid that You'd have to use the HQ button in darkroom.

Aah, I see now what you mean, seems to be a cache issue.

jenshannoschwalm commented 2 months ago

I can't reproduce here yet. Could you provide the image plus xmp, a log with '-d pipe' and the video while you reproduce the issue. That might help.

I guess you are sure your build is ok?

atomikdg commented 2 months ago

Yes my build is ok I tried with clang and gcc: same behavior Yesterday I have reproduced it (not with -d pipe). I'm trying today with -d pipe and give you the log

atomikdg commented 2 months ago

Another info: The warmth colors are exactly like when color calibration module is OFF

jenshannoschwalm commented 2 months ago

Another info: The warmth colors are exactly like when color calibration module is OFF

Ok, so i might have to check with images where there is a big difference between colors before / after color calibration.

I would also be good if you could check if the issue is happening with the temperature settings "camera reference" and / or "as shot to reference"

atomikdg commented 2 months ago

@jenshannoschwalm

On the previous nextcloud link (first post) you will find:

-The XMP + NEF files -Two new videos: bug_clang.mkv and bug_clang_expo/mkv -Two log files (-d pipe) relatives to the videos -A video with camera ref and as shot to ref --> I reproduced the bug with "camera reference". -A video when I activate or deactivate some modules

I can't reproduce it with gcc... but with clang 18.1.8 (I think I was wrong in my previous post but will try when I have some time).

jenshannoschwalm commented 2 months ago

It would be very / extremely important to know if this is a clang-only issue!

github-actions[bot] commented 2 days ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.