search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.76k stars 1.14k forks source link

Histogram Shouldn't Have Max Height #17162

Open johnlb opened 3 months ago

johnlb commented 3 months ago

Describe the bug

In 4.8.0, the height of the histogram was limited. This is a problem for large monitors as it makes it difficult to see the scope.

I submitted a pull request (#17045) a month ago that fixes this, but nothing has happened with it so maybe creating a ticket will at least start a conversation about it.

Steps to reproduce

Resize the histogram and it will stop at a certain point.

Expected behavior

The histogram should be able to be any size

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.0+

What OS are you using?

Linux

What is the version of your OS?

Ubuntu 24.04 on WSL2

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

zisoft commented 3 months ago

Summer time - vacation time. So please be patient.

wpferguson commented 3 months ago

The first month or so after a release is pretty much dedicated to fixing any bugs and getting the .1 release out. After that features and non-critical bug fixes start getting merged.

I usually hold off even submitting my PR's until after the .1 release so I don't "clutter" up the process.

The 4.8.1 release tarball was sent to packagers yesterday. The release should be out next week.

johnlb commented 3 months ago

Gotcha! Thanks so much for the context that is good to know! I don't have a sense of what a normal turnaround time is for this project, so I figured a month was a reasonable amount of patience; sounds like it just happened to be at the wrong time in the design cycle :-)

I was hoping it would go out on the .1 release, since it was introduced in .0 and is kind of an accidentally regressive bug, but I can see how it would not seem that way if you mostly prioritize critical bugs for .1

johnlb commented 1 month ago

Alright the PR went stale after 60 days. I just merged with the latest so I'm pinging this ticket to make sure someone sees it.