search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.52k stars 1.13k forks source link

Framing reflected in Histogram #17214

Open ykhrol opened 1 month ago

ykhrol commented 1 month ago

Describe the bug

When adding a frame to the image it gets reflected in the histogram

I don't have an old version to compare, but I'm pretty sure it wasn't the case in previous releases. It is confusing to see the frame on the histogram

I randomly checked a few modules and those seem to treat the boundaries of the image correctly (exposure, crop worked well)

Steps to reproduce

  1. Open an image in darkroom
  2. Enable framing module
  3. It gets reflected in the histogram

Expected behavior

Frame isn't part of the image and shouldn't be included in the histogram

Logfile | Screenshot | Screencast

Screenshot 2024-07-27 at 23 54 46 Screenshot 2024-07-27 at 23 54 41 Screenshot 2024-07-27 at 23 54 15 Screenshot 2024-07-27 at 23 54 03

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.1

What OS are you using?

Mac

What is the version of your OS?

macOS 14.5

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

ralfbrown commented 1 month ago

Frame isn't part of the image and shouldn't be included in the histogram

It is part of the final image. Otherwise it wouldn't be in the exported result...

There has been talk in the past of allowing the user to connect the histogram to the output of any module, which would allow you to bypass the framing module for the histogram.

ykhrol commented 1 month ago

Thanks for the context! I didn't realise that this was already discussed. And I do agree that the frame is the part of the final image, I should have used a different word to reflect the part of the image being modified/processed.

I am still not sure the histogram should reflect the frame as I personally don't see the value in it and find it rather confusing

I might be wrong in my assumptions/expectations, but to me, the histogram reflects the working range of the image. I use it to control/analyse/adjust the corrections applied. And the frame is not being impacted by any of the modules (at least I assume so based on a quick test). What is the value of reflecting it in the histogram then?

Let's say I add some exposure as I want to make the image brighter or check that colour corrections didn't introduce a tint, having a part of the histogram constant is not helpful and sometimes will hide the effect of the changes

Anyway, I reported this as it looked like a bug. If it's intended behaviour, I guess, I'll have to only apply framing after I'm done with corrections and switch it off if I need further adjustments. But it is definitely confusing and I don't understand what is the use case for this information on histogram

ralfbrown commented 1 month ago

You can restrict the histogram to just a manually-selected portion of the whole image with the color picker module (in the left panel).