search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.79k stars 1.14k forks source link

Grouping of images can add non-selected photos #17306

Open wrobell opened 3 months ago

wrobell commented 3 months ago

Describe the bug

In group mode, when adding images to a group, non-selected photos can be added to a group.

Steps to reproduce

  1. Enter group mode
  2. Select images a.jpg and a.raw - top level message says that 2 images are selected
  3. Press Ctrl-G to group images - group is created as expected
  4. Select images b.jpg, b.raw, and b-1.jpg - top level message says that 3 images are selected; note that b-1.jpg is a distinct file on disk.
  5. Press Ctrl-G to group images - group of 5 images is created and consists of a.* and b* photos
  6. There is one group of images, instead of two

This might happen randomly. Seems more prevalent with hundreds of images in a roll.

Expected behavior

There should be two group of images, not one.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

distro packaging

darktable version

4.8.1

What OS are you using?

Linux

What is the version of your OS?

ArchLinux

Describe your system?

No response

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

wpferguson commented 3 months ago

Can't reproduce on ubuntu 22.04 and current master. I use grouping with thousands of images in a roll and haven't seen this issue.

wrobell commented 3 months ago

My workflow usually involves more steps. Let me try to figure out if the additional steps (or additional images) cause the issue. I hope to provide better description to reproduce the problem within next few days.

github-actions[bot] commented 1 month ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.