darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.52k stars 1.12k forks source link

White balance for ILCE-6700 #17327

Closed sercxanto closed 1 week ago

sercxanto commented 4 weeks ago

Hi Darktable team,

I like to contribute white balance presets for ICLE-6700 (Sony Alpha 6700).

First I tried to run extract_wb.py and create a PR, but when running the script I stumpled across 75 warnings on stderr:

WARNING: no defined sort order for 'Color Temperature/Color Filter'

And the final line

Gaps detected in finetuning for Sony ILCE-6700 preset Color Temperature/Color Filter, dt will need to interpolate!

So I don't know if the resulting JSON file is really valid: ICLE-6700.json

Further investigation by running extract_wb_from_images.sh (see darktable-whitebalance-20240814.tar.gz) revealed that it has something to do with the WB setting "C.Temp/Filter":

RUIDb6d3e0029d7e40cb885ab80d0244241d

Sony's description of "C.Temp/Filter" is the following:

Sets white balance to match color temperature of light source. Color can also be changed as desired.

I made a single shot for every selectable color temperature in Kelvin (skipping changing amber/blue settings). Does it even make sense to record shots for this WB setting? Should I have skipped it?

kmilos commented 4 weeks ago

The Kelvin presets are ok to have, and one doesn't want fine tuning for those.

I'm away from my machine, so can't really look into the warnings for a while unfortunately...

P.S. Should be "ILCE", so please update the title for future reference.

kmilos commented 1 week ago

@sercxanto Thanks for the data. Finally managed to take a look at your JSON file - I'd basically discard all of the "Color Temperature/Color Filter" entries and keep everything from Daylight below (incl. the Kelvin presets)... Are you able to prepare a PR for this perhaps?

sercxanto commented 1 week ago

@kmilos Sound reasonable. I created a MR for it: #17404 (did not test it as I don't have the full dev setup)

kmilos commented 1 week ago

Thanks, looks good I think. You don't need to build anything to test, just replace wb_presets.json in your current installation...

sercxanto commented 1 week ago

@kmilos I replaced the wb_presets.json file and now see the WB settings of my camera.