search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.83k stars 1.14k forks source link

cannot open qoi file format #17560

Closed TurboGit closed 1 month ago

TurboGit commented 1 month ago

I know this has been discussed somewhere but I cannot find the reference. So better tracking this here to ensure it is fixed for 5.0.

TurboGit commented 1 month ago

@victoryforce : Tentatively assigned to you, I kind of remember that you knew where the issue was. Do you remember where we discussed that?

victoryforce commented 1 month ago

@victoryforce : Tentatively assigned to you, I kind of remember that you knew where the issue was. Do you remember where we discussed that?

We discussed it here: https://github.com/darktable-org/darktable/pull/12894#issuecomment-2341736201. The fix is ​​very simple. However, if I do this fix now, it will cause a merge conflict for the #17368. If this PR will be accepted, it would be easier to fix this after its merging.

TurboGit commented 1 month ago

Oh, I forgot about #17368, seems to be ready for review / integration, right?

ralfbrown commented 1 month ago

Didn't see the discussion on 12894 at the time, but merging 17368 should fix the error by recognizing QOI files and specifically invoking the QOI loader on them.

victoryforce commented 1 month ago

@TurboGit There is no issue with 4.9.0-661-gf10d881fcd.

TurboGit commented 1 month ago

Right, no more issue after merging #17368 some hours ago. Closing.