darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.91k stars 1.15k forks source link

Harmonize color input methods #2307

Closed pphotography closed 3 years ago

pphotography commented 5 years ago

Background

The 'split toning' module has got a dedicated color picker with the possibility to choose colors from a palette next to the hue/saturation sliders. This is very useful when you're working with a reference color palette for a picture.

Not every other module uses the color picker. On these modules working with precise color values becomes complicated.

Analysis

I took a look at the various modules that use color (hue) input and made a list out of it.

Modules with color input using a palette selector

Modules with color input without palette selector

Both modules move a color range. Color zones moves a color (hue) range, not a precise color. Color balance moves darker and brighter colors with the sliders. Therefore I don't see that a missing palette is a problem here.

Modules with color picker without palette

Color correction moves two color ranges, no precise color values.

Colorize adds a layer with a specific color value. Here I see the need of picking a defined color, especially when working with a reference palette.

Color look up table works with specific colors, too. It moves colors to specific values. With an implemented color selector for target values the user could give an image a certain look easily. Select an area in the picture, make a new patch in the look up table and choose a target color.

Graduated density can add a colorised gradient. Choosing a gradient with a defined color would be a benefit here, too.

Feature request

For me this leads to the feature requests for adding color selectors with palettes to the modules

This would harmonize color input methods in the system and give the users new abilities within it.

github-actions[bot] commented 4 years ago

This issue did not get any activity in the past 30 days and will be closed in 7 days if no update occurs. Please check if the master branch has fixed it since then.