search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.77k stars 1.14k forks source link

[darkroom] filmstrip jumps to first pic when changing rating-view #5735

Closed AxelG-DE closed 3 years ago

AxelG-DE commented 4 years ago

Describe the bug

When changing the rating view e.g. between 3 back to 1, the filmstrip jumps to first pic in collection.

To Reproduce

  1. Go to 'darkroom' with a collection having approx. 50 pics in 3 and many more in 1. place your fokus somewhere in the middle of 3* selection
  2. Change from 3 down to 1
  3. See error

Expected behavior Same than lighttable, the focus shall stay centred from where the user left one rating to another (if in the new collection is no such pic, stay very near to that position in the collection)

Platform (please complete the following information):

AxelG-DE commented 4 years ago

@AlicVB may I ping you here? :slightly_smiling_face:

AlicVB commented 4 years ago

@AxelG-DE : this is more a feature request than an issue, as it's not implemented now (in filemanager too) currently, when you refilter the collection, the offset is keep only if the image is still in the new collection, otherwise, it's reseted to beginning.

Implementing the case you want would require quite a lot of work and I'm not even sure there's good way to do it as the collection may very well have changed completely... Need more thought !

I've just fixed a small glitch in filmstrip where in this case, the filmstrip is moved to the right with no centered image.

Nilvus commented 4 years ago

I would add that filmstrip display is also related to filters settings on top bar, so this will work differently regardless of filters settings and that's quite normal. I'm not really sure to understand what you describe so If I'm not on, please excuse me. But on what I understand, you change filter so filmstrip display is updated to that filter change, so just what is wanted. So, as @AlicVB says: if the image selected before filter change is always visible, that's normal to see that image always selected but if not, so that seems normal for me that darktable, as he has no selected image displayed, go back to first picture.

AxelG-DE commented 4 years ago

@AxelG-DE : this is more a feature request than an issue, as it's not implemented now (in filemanager too) currently, when you refilter the collection, the offset is keep only if the image is still in the new collection, otherwise, it's reseted to beginning.

Which is very annoying in big collections :-)

My workflow is (each vacation trip I come back with way above 1.000 pics):

From time to time I switch either from =3 to =2 or from =3 to >=2 or <=3 to find another pic (maybe a sharper one). That is the moment it gets annoying, when you have to find back, where did you come from.... If I am at pic-ID e.g. 3500 and I change from =3 to =2*, indeed there is no pic-ID 3500 but MAYBE a pic-ID 3487 and maybe a a pic-ID 3698. Then I would appreciate to be located close to those....

From my perspective I think my workflow is not that special and I am surprised, nobody else speak that out...

Implementing the case you want would require quite a lot of work and I'm not even sure there's good way to do it as the collection may very well have changed completely... Need more thought !

I see.... Maybe also my description here is still not good enough, I am 40% with my mind still in my job, sorry for that...

I've just fixed a small glitch in filmstrip where in this case, the filmstrip is moved to the right with no centered image.

Actually I also faced once, filmstrip moved totally to the left and no pic centred or highlighted...

@Nilvus Did my explanation make it a little more clear and a little sense? I hope so otherwise I need to spend more energy for proper explanation :)

Nilvus commented 4 years ago

@AxelG-DE: your explanation si clear now. I found your workflow quite complicated and it's probably not used that way by a lot of people (but I could be wrong) and maybe that why nobody else speak about that.

I never change ratings on darkroom. I always set them on lighttable and often with culling mode by comparing images. But I'm someone not conservative so I always remove lot of photos (and sometimes come back to old photos and delete some). So, even if I have 2000 pics, I rarely keep a lot more than a hundred ones, sometimes less. I then rate them and after edit them. And I never use ratings filters on darkroom.

AxelG-DE commented 4 years ago

My explanation is not good enough, LOL

Mainly I do the rating in lighttable too. Just in between the edit I do it sometimes in darkroom and sometimes in lighttable. Both with same annoying result :-)

Nilvus commented 4 years ago

My explanation is not good enough, LOL

Mainly I do the rating in lighttable too. Just in between the edit I do it sometimes in darkroom and sometimes in lighttable. Both with same annoying result :-)

Your explanation is good enough, be sure for that. Just different view of workflow. Just to be sure, in lighttable, you have only filmstrip on culling and preview view and of course, filmstrip works the same way on all views. To be more precise, I personally rarely use filmstrip, and when using it, it's only on darkroom.

AxelG-DE commented 4 years ago

IIRC the issue is the same with the shown pics in lighttable view's main window...

EC1000 commented 4 years ago

It would be a nice addition to be able to keep the "nearest" image selected, when changing rating and even collection.

I found your workflow quite complicated and it's probably not used that way by a lot of people (but I could be wrong) and maybe that why nobody else speak about that

I use kind of a similar workflow. Not exactly the same, but I also do several rounds of rating to add stars or sometimes remove one/reject (with more or less a target proportion bewteen the number of each ratings). Thus when changing between rating (>= or =, number of stars), I also sometimes "lost my position". For example just when changing between 2 and 3 ; my "workaround" is to go on a 3-star picture before changing the filter, but being able to not mind about that would indeed be a nice improvement.

In can also happen with collection (example with color label, which may have a signification like rating to define a "sub-collection"), even if that is less often for me.

github-actions[bot] commented 4 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

pahl34 commented 4 years ago

Edit: Found that it behaves differently in culling mode, so I will use that one instead.

Edit 2: Now it also behaves as desired in file manager mode...I am confused.

To be honest, I actually have the same issue quite regularly in the file manager view of lighttable (darktable version 3.2.1 on windows 10). Consider this situation, which I often run into:

I have imported a bunch of images and rated them already in lighttable, e.g. everything >= 2 I would like to consider for editing in darkroom. Before starting to edit, I want to be sure I did not miss any "good picture", so I set the lighttable filter to 'all photos < 2". Now I only get the pictures I had eliminated or rather "not chosen for further editing" before. Whenever I change my mind about one of these pictures and now I actually want to consider it for editing, I'll give it a 2 rating. The picture will get removed from my current selection and the focus jumps back to the first picture matching the still active 'below 2' filter. This is quite annoying, because to go on I first have to find the spot where I was before.

I understand that this may be hard to change/fix, so is there maybe a better/more common lighttable workflow for picking the pictures worth editing? Thanks!

pahl34 commented 4 years ago

I now was able to reproduce the problem again:

To me, this seems to be a bug rather than a missing feature, as it works in one way but does not work the other way.

@AlicVB, @Nilvus: As it seems the discussion about this issue never really came to a clear end - may I thus ask you about your opinion again? Am I just misunderstanding how lighttable works or is this indeed a bug? Just trying to help making darktable even better. Thanks!

Nilvus commented 4 years ago

@pahl34: what you describe about rejecting left picture goes to the very first picture seems more a bug than a feature. I always use culling same way as yours (but not this week) and I don't remember having such issue.

Could you precise which culling mode you use: dynamic or fixed one? And if possible, could you reproduce that on both dynamic and fixed mode or only one?

pahl34 commented 4 years ago

@Nilvus: Thanks for your quick reply. I use culling with fixed zoom to reproduce the described issue.

I just tried to reproduce it as well in dynamic zoom mode, however I think I do not understand how this mode works at all, or I cannot get it to work. Whenever I enter that mode, there is a message "no image selected". However, I do not find a way to select any image from the filmstrip on the bottom, except "Ctrl+A" which selects all images in the current selection and displays them in the main pane (in small size, so all of them fit in). Then, if I try to zoom using "Ctrl + Mouse Wheel", nothing happens, but I get a message "zooming is limited to 4 images". Thus, I was not able to try to reproduce the problem described above (the one I have in fixed zoom mode), because I never reach the situation in which it would occur in dynamic zoom mode.

Nilvus commented 4 years ago

@pahl34: so first I suggest you to read 3.0 and 3.2 articles in darktable.org/blog. That will help you understand those modes and some shortcuts for filmstrip. That will also, probably, learn you some great things about darktable and how to better use it.

pahl34 commented 4 years ago

@Nilvus: Thanks for the hint and sorry for having wasted your time. I read the articles you mentioned and I now understand much better how culling mode works (it's actually great!). I think my main problem was to not know about the Alt+Click in order to start a new selection on the film strip, but there was surely much more for me to learn from the articles. Before, I had only checked the section about culling in the 3.0 manual but in future I'll make sure to read all available documentation and blog entries more carefully before posting here!

I have to admit that now I cannot reproduce the problematic behavior anymore, neither in file manager, nor in fixed or dynamic zoom modes of culling. While I am very sure that I actually reproducibly had this behavior earlier, I now have to assume that the reported error was caused by another operating error on my part. Probably the software was actually behaving as designed but I just misinterpreted its behavior because of my lack of understanding. In case I'll ever find out what steps exactly caused the behavior, I'll post again here - then we could still see whether there might be a bug, but for now (at least until I can prove otherwise) I will consider my report a "false alarm".

Thanks for your help and sorry again for posting before fully understanding how the interface works.

AxelG-DE commented 4 years ago

@parafin why my issue got closed? The discussions between Nilvus and pahl34 do not actually solve my problem

parafin commented 4 years ago

sorry

AxelG-DE commented 4 years ago

No problem 🙂 Thanks for reopening.

pahl34 commented 4 years ago

Sorry for having caused confusion here.

I just now realized after reading again AxelG-DE's initial post, that the original issue/feature request is something different than the "maybe-bug" I described. So I should not have posted in this discussion in the first place, but, if at all, opened a new one.

So for any further discussion about the original topic please do not get confused by my postings, they were actually off-topic in this context.

pahl34 commented 4 years ago

I think I found out what my problem posted in my comment from 02. of october was and documented it in issue #6566.

Nilvus commented 4 years ago

@pahl34: so maybe closing this issue would be good. Issue #6566 is clear (title is just hard to read!) and @AlicVB already assign it to him. That means he will check that.

pahl34 commented 4 years ago

I believe that this issue 5735 describes another problem. I think it is about the behavior when changing the view filter, not when changing the rating of an image. It was my mistake to think it was describing the same problem I was facing. It even had been closed already some weeks ago after my postings but the original author of that issue complained that it was indeed something else and then it was reopened (see above the activities by parafin and AxelG-DE). So I think this issue should stay open - at least it should not be closed because of my findings.