search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.44k stars 1.12k forks source link

Build failure on windows 10 : missing execinfo.h #6166

Closed chhil closed 3 years ago

chhil commented 3 years ago

probably related to @johnny-bit changes.

Clean build directory

F:/msys64/home/chill/darktable/src/control/signal.c:24:10: fatal error: execinfo.h: No such file or directory
   24 | #include <execinfo.h>
      |          ^~~~~~~~~~~~

shell script used 

#!/bin/bash
cd ~
#rm -R ./darktable/
git clone git://github.com/darktable-org/darktable.git

cd darktable
git pull
#git checkout 580bf49
git submodule init
git submodule update
mkdir build

cd build
cmake -G "MSYS Makefiles" -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=./debugReleaseWithDebugDT ../.
cmake --build .
cmake --build . --target install
cmake --build . --target package
johnny-bit commented 3 years ago

please check if #6168 fixes compilation problem for you :)

chhil commented 3 years ago

I only build master, the change is not in it, so it fails.

From git://github.com/darktable-org/darktable d25a47d7f..7c3e32917 master -> origin/master Updating d25a47d7f..7c3e32917 Fast-forward src/iop/temperature.c | 2 ++ src/libs/collect.c | 10 ++++++++++ src/libs/lib.c | 2 +-

johnny-bit commented 3 years ago

try for time being temporarly change files from that PR and build. Or you can install libbacktrace but I wouldn't recommend that ;)

wt., 1 wrz 2020 o 10:46 Murtuza Chhil notifications@github.com napisał(a):

I only build master, the change is not in it, so it fails.

From git://github.com/darktable-org/darktable d25a47d https://github.com/darktable-org/darktable/commit/d25a47d7fc3395e0f274f6031cb23b4930f2848c ..7c3e329 https://github.com/darktable-org/darktable/commit/7c3e3291787f90dfed9c10b71f85a24553588ec0 master -> origin/master Updating d25a47d https://github.com/darktable-org/darktable/commit/d25a47d7fc3395e0f274f6031cb23b4930f2848c ..7c3e329 https://github.com/darktable-org/darktable/commit/7c3e3291787f90dfed9c10b71f85a24553588ec0 Fast-forward src/iop/temperature.c | 2 ++ src/libs/collect.c | 10 ++++++++++ src/libs/lib.c | 2 +-

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/6166#issuecomment-684591909, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRRKFK6NTJZMLUX4VDZDN3SDSYFNANCNFSM4QRI2X6A .

-- Pozdrawiam, Hubert Kowalski

chhil commented 3 years ago

Did manual merge of the 2 file changes.

Did not fail with missing header file but did fail later on. A snippet of output from end when it failed.

....
F:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/lib_darktable.dir/objects.a(styles.c.obj):F:/msys64/home/chill/darktable/src/lua/styles.c:215: more undefined references to `dt_print' follow
collect2.exe: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/lib_darktable.dir/build.make:2812: src/libdarktable.dll] Error 1
make[1]: *** [CMakeFiles/Makefile2:1321: src/CMakeFiles/lib_darktable.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
chhil commented 3 years ago

Full output of build. Lot of undefined references.

build.txt

matt-maguire commented 3 years ago

I tried to build, I needed PR #6168, and then it built fine in Windows 10 off master branch

Make sure when you start the terminal, you are using the one named "MSYS2 MinGW 64-bit" and not "MSYS2 MSYS" -- when I made that mistake before I also had lots of linking problems.

chhil commented 3 years ago

Matt, I always use MSYS2 MinGW 64-bit. It's a pinned shortcut on my taskbar.

I copied the complete files instead of the specific changes and it builds fine.

Thank you.

todd-prior commented 3 years ago

@chhil Did this work for you. I updated my mysys2 and tried to build and I got errors. I have not built from master in some time...I have attached my log files incase that gives any tips...maybe I will try again and see...not sure what the issue might be...[ CMakeError.log CMakeOutput.log

](url)

johnny-bit commented 3 years ago

@todd-prior my fix is in master, please try it.

chhil commented 3 years ago

@todd-prior I haven't updated msys in a long time. I have the files from the commit and it builds fine.

todd-prior commented 3 years ago

Thanks I must have another issue I even wiped my dir and re cloned the latest from git but still not getting all the way through

Get Outlook for Android

From: Murtuza Chhil notifications@github.com Sent: Sunday, September 6, 2020 9:26:31 PM To: darktable-org/darktable darktable@noreply.github.com Cc: Prior,Todd priort@mcmaster.ca; Mention mention@noreply.github.com Subject: Re: [darktable-org/darktable] Build failure on windows 10 : missing execinfo.h (#6166)  

@todd-prior I haven't updated msys in a long time. I have the files from the commit and it builds fine. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

todd-prior commented 3 years ago

I cloned the latest last night but I will followup and see...

Get Outlook for Android

From: Hubert Kowalski notifications@github.com Sent: Sunday, September 6, 2020 2:25:20 PM To: darktable-org/darktable darktable@noreply.github.com Cc: Prior,Todd priort@mcmaster.ca; Mention mention@noreply.github.com Subject: Re: [darktable-org/darktable] Build failure on windows 10 : missing execinfo.h (#6166)  

@todd-prior my fix is in master, please try it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

todd-prior commented 3 years ago

@johnny-bit ...I think I have a different issue..this is where I am getting hung up
" WIN32: Adding dependency files to install CMake Error at cmake/windows-macros.cmake:183 (file): file failed to open for reading (No such file or directory):"

matt-maguire commented 3 years ago

@todd-prior seems to be related to lensfun, did you install it and do lensfun-update-data?

todd-prior commented 3 years ago

Okay thanks for the tip …I was just going over the lines in the windows build file and pasting the lines in to update all based on the latest instructions…I see that it is installing .03.95 and I wonder if that has messed it up….I thought I had the lines in to ignore the lensfun update but apparently not….if so that should be corrected in the documentation…I thought maybe it supported it now when I saw it install……..

I have downgraded it and look to be back in business…

So grateful for your tip…saved me a lot of time….really appreciate it…

All the best

From: Matt Maguire notifications@github.com Sent: September 6, 2020 11:17 PM To: darktable-org/darktable darktable@noreply.github.com Cc: Prior,Todd priort@mcmaster.ca; Mention mention@noreply.github.com Subject: Re: [darktable-org/darktable] Build failure on windows 10 : missing execinfo.h (#6166)

@todd-priorhttps://github.com/todd-prior seems to be related to lensfun, did you install it and do lensfun-update-data?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/darktable-org/darktable/issues/6166#issuecomment-688002158, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKS2ESZCVEGGXRZQAHXXGWLSERGETANCNFSM4QRI2X6A.

todd-prior commented 3 years ago

I didn’t quite make it

[ 93%] Generating de/darktable-cmstest.pod Unknown format type: pod. List of valid formats:

From: Matt Maguire notifications@github.com Sent: September 6, 2020 11:17 PM To: darktable-org/darktable darktable@noreply.github.com Cc: Prior,Todd priort@mcmaster.ca; Mention mention@noreply.github.com Subject: Re: [darktable-org/darktable] Build failure on windows 10 : missing execinfo.h (#6166)

@todd-priorhttps://github.com/todd-prior seems to be related to lensfun, did you install it and do lensfun-update-data?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/darktable-org/darktable/issues/6166#issuecomment-688002158, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKS2ESZCVEGGXRZQAHXXGWLSERGETANCNFSM4QRI2X6A.

matt-maguire commented 3 years ago

That is probably due to missing perl pod parser (it was dropped from a recent perl update). I ran into the same issue when I was building the docs on linux, and I solved it by installing the appropriate perl module with my distro's package manager. Not sure the easiest way to handle that on Windows; I normally just build the code on windows, and do the doc builds on linux only.

todd-prior commented 3 years ago

Your right...did an update and got it so things are working now...thx

Get Outlook for Android

From: Matt Maguire notifications@github.com Sent: Monday, September 7, 2020 8:02:57 PM To: darktable-org/darktable darktable@noreply.github.com Cc: Prior,Todd priort@mcmaster.ca; Mention mention@noreply.github.com Subject: Re: [darktable-org/darktable] Build failure on windows 10 : missing execinfo.h (#6166)  

That is probably due to missing perl pod parser (it was dropped from a recent perl update). I ran into the same issue when I was building the docs on linux, and I solved it by installing the appropriate perl module with my distro's package manager. Not sure the easiest way to handle that on Windows; I normally just build the code on windows, and do the doc builds on linux only. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.