darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.9k stars 1.15k forks source link

Denoise (profiled) : Noise profiles not loading for Nikon DSLR cameras (JPG pictures) #6644

Closed GLLM closed 1 year ago

GLLM commented 4 years ago

Hello all,

I'm running Dt 3.2.1 on Linux Kubuntu 20.10

I'm using Denoise (Profiled) module and it works perfectly with my Fujifilm X-T3 camera.

But, when I'm retouching photos (JPG) taken with (not owned anymore) Nikon DSLRs, the profile is neither seen nor loaded/loadable in this module.

image

I've looked into noiseprofiles.json file and wonder if this could be caused by the fact that :

Camera & Maker as visible on one of my pic : image

Camera list of my collection image

I've therefore edited /usr/share/darktable/noiseprofiles.json and I've tested changing "Nikon" maker to "NIKON CORPORATION" and "D600" to "NIKON D600" and .... hurrah, the camera is recognized and therefore the noise profile is visible and can be loaded.

image image

Questions

Usual addendum :

Thanks GLLM

GLLM commented 4 years ago

Up !

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

johnny-bit commented 3 years ago

I think this might be unfixable by darktable but rather it might be a combination of couple issues:

How about this - try to remove and then re-import images, making sure you have recent enough verson on exiv2. If that helps - please close the issue :)

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

GLLM commented 3 years ago

Hi @johnny-bit ! Thanks for your reply !

It happens that I had to rename (externally) 10k+ pictures taken with my previous Nikon DSLR ... hence I had to re-import them in dt. And unfortunately, this did not solve anything !

About JPEG : the denoise (profile), when used wisely & lightly, can help greatly ... even on JPEGs :-)

I just reinstalled exiv2 0.27.3 ... to no avail.

Indeed, on a RAW (NEF) file, it works ok. In fact, the Maker & Model (and evn lens) info are different between the NEF and the JPEG files ! Not sure why, as I did not change any of them :

JPEG image

NEF (RAW) image

So, I'm indeed not sure how to deal with this.

Oh, and I don't know why, but Lens correction module does not bother : it works with both

Thanks GLLM

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

jonplarson commented 1 year ago

I just encountered a similar Issue with my Nikon Z 6ii Where the profiles didn't show up due to the naming differences.

kmilos commented 1 year ago

See also discussion at https://github.com/darktable-org/darktable/issues/13712

Indeed something going on...