darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.8k stars 1.14k forks source link

Parametric Masks finer control #8194

Closed SoupyGit closed 1 year ago

SoupyGit commented 3 years ago

Is your feature request related to a problem? Please describe. The parametric mask currently features 4 markers, 2 top, 2 bottom. The manual states, "The sequence of the markers always remains unchanged: they can touch one another but they cannot switch position." The problem is, not being able to switch position limits the potential of the tool.

Describe the solution you'd like I would like the markers to be able to switch position, or at the least, for the top 2 markers to be able to switch position. For example, in g channel, the black top can be placed at value 100, while the white top can be placed at value 0, at the same time.

In other programs that allow it, I use this feature when making black or white to transparency gradients - it can be a nice way of adding contrast in only certain parts of the image (the black to transparency gradient on opposite side of light direction, the white to transparency gradient on same side as light direction). Used this way, it can also be a way to redo lighting in post. It would be great to be able to use darktable for this and not rely on other programs, and it would be possible using the graduated density filter, if the markers could switch position.

It would probably also require a styling change. Currently, both top markers are the same shade solid grey, while both bottom markers are the same shade with same border. This is not a problem when sliders can't switch, but if sliders can switch, it would be confusing which is which. Therefore the 'black' markers should be a dark/black shade, while the 'white' markers should be a light/white shade.

elstoc commented 3 years ago

I'm not entirely sure what you're trying to achieve here. Have you tried inverting the mask with the +/- button?

parafin commented 3 years ago

I guess the idea is to create a /\ curve that doesn't go up to 100%?

SoupyGit commented 3 years ago

Does this help? Current mask allows this: /\ I would like this: X

For example, photoshop.

PS blend if

Where 'this layer' is equivalent to 'output' and 'underlying layer' is equivalent to 'input'. 'This layer' in screenshot represents default settings. My adjustments to 'underlying layer' shows the X shape, with white and black switching sides.

Might be able to post some examples of what can be achieved in the coming days, but a bit under the weather, and busy, right now!

SoupyGit commented 3 years ago

OK, I have finally got around to doing a couple of picture examples. The first raw is available here: https://discuss.pixls.us/t/playraw-tree-in-park/20938

Initial edit in DT (no graduated densities) tree-in-park-IMG_2464-dtnograd : Edit in DT + best attempt using graduated densities and parametric mask: tree-in-park-IMG_2464-dtgrad

[I tried to upload xmp but Github says "we don't support that file type"]

Initial edit in DT (no graduated densities), exported as 16bit tiff linear rec 2020, opened in PS where I added a very subtle light > transparency gradient, and a dark > transparency gradient, with a 'blend if' mask as per the screen shot. tree-in-park-IMG_2464_01-psgrad

tree-in-park-shadowsgrad

This is a good test image for the cause, as the lighting is flat, and this technique allows to make the lighting a little more dynamic. We can see the PS edit allows for greater subtlety and naturalness than the darktable with graduated density, due to the finer control achievable in masks.

The second raw is available here: https://discuss.pixls.us/t/help-with-a-poorly-lit-portrait/20538

Initial edit in DT (no graduated densities): portrait-girl-red-DSC_2839-dtnograd

Edit in DT with graduated densities: portrait-girl-red-DSC_2839-dtgrad

Initial edit in DT (no graduated densities), exported as 16bit tiff linear rec 2020, opened in PS where I added a light > transparency gradient, with a 'blend if' mask as per the screen shot, and a dark > transparency gradient. portrait-girl-red-DSC_2839-psgrad

portrait-girl-red-highlightgrad

Again we see the last version give a more subtle result. But the area I'd like you to pay particular attention to is the girls shirt - the texture and shadows. In the DT version it looks so much flatter. It is the masking options in PS that make texture like that possible.

chhil commented 3 years ago

[I tried to upload xmp but Github says "we don't support that file type"]

Rename the file to have a txt extension and then you can upload it.

SoupyGit commented 3 years ago

Ah, excellent. Here are the xmp's. These contain the gradients used in darktable. Just turn the gradients off to see how it looked without (as per initial edit, and version exported as tiff for PS).

tree-in-park-IMG_2464.CR2.xmp.txt portrait-girl-red-DSC_2839_02.nef.xmp.txt

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 300 days with no activity. Please check if the newest release or nightly build has it fixed. Please, create a new issue if the issue is not fixed.