darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.78k stars 1.14k forks source link

Browse button on Copy & Import dialogue #9548

Closed brucewilliamsphotography closed 3 years ago

brucewilliamsphotography commented 3 years ago

Hi devs, The new import dialogue is a beautiful leap forward, but is, in my humble opinion, lacking one final feature. Open up the import dialogue box, and select "Copy & Import". Twirl the down arrow for the "Naming rules" section. See the "Base directory naming pattern" field? It needs a 'browse' button on the right hand end, so you could simply browse to a parent folder, and have that path loaded into the field. For me, this would be the final nail in the coffin for Rapid Photo Downloader. At the moment, you need to pull up your system's file browser, find the parent directory (you wish to copy your images to), copy the path, and then paste it into the "Base directory naming pattern" field. Thanks in advance for the consideration!

johnny-bit commented 3 years ago

This field supports variables, that's why it doesn't have browse button AFAIK. But I don't think adding such button would hurt the field functionality...

elstoc commented 3 years ago

So something similar to how the export module works?

brucewilliamsphotography commented 3 years ago

Yeah! Just like that!

Cheers, Bruce Williams.

On Sat, 17 Jul 2021, 00:50 Chris Elston, @.***> wrote:

So something similar to how the export module works?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/9548#issuecomment-881506688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB4ZDU6MQAJAE3ZDF5BG3LTYBBJ5ANCNFSM5APPFXFQ .

johnny-bit commented 3 years ago

Can you try PR #9556 ? should cover your needs :)

brucewilliamsphotography commented 3 years ago

Hubert, Thanks! When you say "could I try it", are you saying I can somehow build this from source now? Cheers, Bruce Williams

brucewilliamsphotography.com shuttersincpodcast.com

e-mail @.> | Twitter @.> | LinkedIn http://au.linkedin.com/pub/bruce-williams/1/318/489 | Facebook http://www.facebook.com/audio2u

On Sat, Jul 17, 2021 at 8:37 PM Hubert Kowalski @.***> wrote:

Can you try PR #9556 https://github.com/darktable-org/darktable/pull/9556 ? should cover your needs :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/9548#issuecomment-881874276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB4ZDS4LE3AVEMOEUNGOKLTYFMNLANCNFSM5APPFXFQ .

johnny-bit commented 3 years ago

It's not in master, no... If you can try the PR it'd be great ;) or I can make a screenshot...

brucewilliamsphotography commented 3 years ago

Sorry... bit of a noob on this stuff. What do I do to try the PR? Cheers, Bruce Williams

brucewilliamsphotography.com shuttersincpodcast.com

e-mail @.> | Twitter @.> | LinkedIn http://au.linkedin.com/pub/bruce-williams/1/318/489 | Facebook http://www.facebook.com/audio2u

On Sat, Jul 17, 2021 at 9:26 PM Hubert Kowalski @.***> wrote:

It's not in master, no... If you can try the PR it'd be great ;) or I can make a screenshot...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/9548#issuecomment-881881025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB4ZDWGMOMWJ3ERLXGHXUDTYFSFLANCNFSM5APPFXFQ .

johnny-bit commented 3 years ago

That depends on how you bulid from source.

personally i have this alias in my ~/.gitconfig:

[alias]
    pr = "!f() { git fetch -fu ${2:-upstream} refs/pull/$1/head:pr/$1 && git checkout pr/$1; }; f"
    pr-clean = "!git checkout master ; git for-each-ref refs/heads/pr/* --format=\"%(refname)\" | while read ref ; do branch=${ref#refs/heads/} ; git branch -D $branch ; done"

and to test PR i just do

git pr 9556

then compile normally

and after I'm done testing

git pr-clean

Or... you could wait for others to test and then test if it makes to master :)

brucewilliamsphotography commented 3 years ago

I understood "That depends on how you bulid from source.". :) I guess I'll just wait! Cheers, Bruce Williams

brucewilliamsphotography.com shuttersincpodcast.com

e-mail @.> | Twitter @.> | LinkedIn http://au.linkedin.com/pub/bruce-williams/1/318/489 | Facebook http://www.facebook.com/audio2u

On Sat, Jul 17, 2021 at 9:38 PM Hubert Kowalski @.***> wrote:

That depends on how you bulid from source.

personally i have this alias in my ~/.gitconfig:

[alias] pr = "!f() { git fetch -fu ${2:-upstream} refs/pull/$1/head:pr/$1 && git checkout pr/$1; }; f" pr-clean = "!git checkout master ; git for-each-ref refs/heads/pr/* --format=\"%(refname)\" | while read ref ; do branch=${ref#refs/heads/} ; git branch -D $branch ; done"

and to test PR i just do

git pr 9556

then compile normally

and after I'm done testing

git pr-clean

Or... you could wait for others to test and then test if it makes to master :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/9548#issuecomment-881884442, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB4ZDWH6TO2TF2IFDALNTDTYFTRVANCNFSM5APPFXFQ .