darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.07k stars 1.1k forks source link

New preference for Collections module #9589

Open brucewilliamsphotography opened 2 years ago

brucewilliamsphotography commented 2 years ago

I had a youtube viewer ask about why the Collections module always defaults to Film roll, and why it couldn't default to Folders? I think he'd come from LIghtroom, where the default IS a folder/tree view. I wonder how the devs feel about adding a new Preference in the lighttable tab, called something like "Default Collections search criteria", with a drop down menu that offers either FIlm roll or Folders? For that matter, how hard would it be to offer ALL the search criteria, so a user could choose any of them as their own default? Me personally? I find I use Tag more than any other option. I'd probably set that as my default if I had the choice. Thoughts?

elstoc commented 2 years ago

Presumably you mean the fact that it reverts back to film roll when you import (in order to show you the images you've just imported)? Because other than that darktable remembers the search criteria you last used.

What behaviour would you like on import? For it to not show you the imported items? To show all items? I think for this behaviour only a choice between film roll and folder would really work. I have some standard searches I run and have saved them as presets.

brucewilliamsphotography commented 2 years ago

If you hit the reset button for the Collections module, it reverts to Film roll as the search criteria. What I was suggesting was a Preference which would become the default should a user ever hit the Collections module reset button.

elstoc commented 2 years ago

Sure. But do you think import should still work the same? Currently it needs to be on film roll or folder mode in order to show the images imported (without also showing the whole of your library).

brucewilliamsphotography commented 2 years ago

I think it would be reasonable for the collections module to switch to film roll upon import of an image (or sequence of images), but then if the user has set a different search criteria as their default, then hiring reset would then switch to that search criteria.

emoryy commented 2 years ago

I think that simply making the reset button switch to a user defined default preset wouldn't have much merit. It only would spare one click compared to when selecting a preset from the dropdown menu.

Currently with a saved preset the selection is also saved, so when switching to folders view (or other preferred preset) you always need to navigate to the category that includes the newly imported photos. With a deeply nested folder structure that is annoying and tiresome.

So for me the main problem is that the collections module switches view by itself after importing, and I need to renavigate it to the category I want. I can see how the base behavior may be okay for new users or for those who don't care much about folder structure, so it probably should be kept as default.

My proposal would be for the collections module to have a "fixed mode", which would mean that importing (or any other automatism) doesn't cause it to switch search criteria or presets.

A good question then is what should happen after importing? With "fixed mode" the collections module potentially could be in a mode when all newly imported photos couldn't be displayed at once in one category (or "filmroll") on the screen. But when someone uses the module in this mode (explicit choice on their part), this should be expected. I think that it would be a good assumption, that the view should navigate to the category which includes the very last photo from the freshly imported batch of photos.

My main method to get photos into Darktable is by using an other photo management program (specifically Geeqie): I select the photos, right click, and send to Darktable. If I select multiple photos, then they are always in the very same folder. So for me this "fixed mode" would also mean that I would be able to see all the newly imported photos, but with the collections module already showing the correct state without any extra steps.

phweyland commented 2 years ago

Side comment. Ctrl-Shift double click toggles between film roll and folder. This is a quick way to go the right folder collection after importing.

brucewilliamsphotography commented 2 years ago

Oh, I did not know about that keyboard shortcut.... That's great to know!

Cheers, Bruce Williams.

On Sat, 24 Jul 2021, 05:35 Philippe, @.***> wrote:

Side comment. Ctrl-Shift double click toggles between film roll and folder. This is a quick way to go the right folder collection after importing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/9589#issuecomment-885870713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB4ZDUX57UTINRN6SXL6A3TZG76LANCNFSM5AZB4JVQ .

Solarer commented 2 years ago

@emoryy I really like your suggestion. I would maybe implement it as a new preference setting called "switch to film roll mode after import" and activate it by default. That would not impact the current behavior of Darktable but if somebody wants to stay in whatever mode they are in after importing pictures, they can just disable the tickbox.

elstoc commented 2 years ago

if somebody wants to stay in whatever mode they are in after importing pictures

It's not just the mode you're in though. If I had a tag filter in place and then imported a directory I would then need another action in order to be able to see my just-imported images (because they would be imported without tags and would not be visible). The reason it switches to film roll mode on import is because it is assumed (reasonably) that if you've just imported images, you now wish to work on them.

phweyland commented 2 years ago

I would maybe implement it as a new preference setting called "switch to film roll mode after import" and activate it by default.

I think it would be possible for [add to library]. The destination folder exists and is known at the beginning. The right selection can be activated. This is not the case for [copy & import].

bobobo1618 commented 2 years ago

FWIW, I came here because I don't want to see imported images after adding them. I know I'm an edge-case but I'd really appreciate an option in the import parameters to not change my filters.

Alternatively, I'd like an easy way to revert to the stack of filters I previously had.

The reason for this is that usually I'm doing something else when I trigger an import. I want it to happen in the background without interrupting my normal tasks.

Unfortunately, I'm assuming because of a bug or something, while an import is running, it repeatedly resets the filter UI, so I can't navigate my folder tree.

brucewilliamsphotography commented 2 years ago

You CAN get back to the previous set of filters by going to the next module below Collections, which is called Recently used collections, and selecting the second entry in the list (as the top entry will be the newly-imported images).

Cheers, Bruce Williams.

On Wed, 18 Aug 2021, 01:54 bobobo1618, @.***> wrote:

FWIW, I came here because I don't want to see imported images after adding them. I know I'm an edge-case but I'd really appreciate an option in the import parameters to not change my filters.

Alternatively, I'd like an easy way to revert to the stack of filters I previously had.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/9589#issuecomment-900418458, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB4ZDQPMWIT3BFR3PPDGOTT5KAZJANCNFSM5AZB4JVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

github-actions[bot] commented 2 years ago

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] commented 1 year ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

vancouverbluesea commented 7 months ago

The collections module is ... can be challenging at times. My organization is something like this image

Main point is - I use folders - all the time. Film roll - never. During processing - I end up some times moving images from one folder to another and/or importing new images. Example being - images are exported to .tiff for panorama stitching then the composite .tiff is imported back in darktable. These going back and forth is unavoidable as many panoramas are taken in a few seconds - no tripod. Then I use hugin to align and stitch (or even create stacks).

Long story short - DT changing back to film roll is annoying but not to the point to start complaining much and I do remember @TurboGit introduced some improvements in the past.

Ideally (in my opinion) once the user selects "folders" the program should remain in "folders" view - regardless if the user navigates or imports or moves images around.

As I have bookmarks to the main folder - I normally use it as as an approach to always go to the root folder.

And there are days when I have to manage several panoramas and sadly to admit but it gets to me.

I know you guys have done a phenomenal work with DT. And this issue is far from being a high priority. If you are able to find time and and approach to fix this - it would mean a lot for me.

Thank you in advance!

B.

github-actions[bot] commented 5 months ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

pozix604 commented 2 months ago

Very late to this party, but I side-stepped this limitation by defining a preset on collections to view all folders, then setting the % shortcut key to it.

vancouverbluesea commented 2 months ago

Very late to this party, but I side-stepped this limitation by defining a preset on collections to view all folders, then setting the % shortcut key to it.

This is a good suggestion. Thank you! I also realized that % works well in filmrolls. (ashamed to admit but I could have tried earlier) While I still believe that once the user switches to folders - the system should continue that not switching back to filmrolls - in my particular workflow - for now the % turns out to be invaluable tool.

github-actions[bot] commented 2 weeks ago

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

Solarer commented 2 weeks ago

Still relevant

Solarer commented 2 weeks ago

Would this be an acceptable solution?

  1. Importing does never change the display of the collections module.
  2. Implement an option whether to switch to newly imported images or stay where you are

I have not looked at the code but surely it should be possible to open a collection (e.g. newly imported images) without changing the view in the collections module. Thus allowing us to see new images even if they span multiple directories while staying in folder mode

elstoc commented 2 weeks ago

I can't imagine ever wanting to import and not to immediately see the things I just imported.

wpferguson commented 2 weeks ago

We have like 3 different issues all mixed in here....

surely it should be possible to open a collection (e.g. newly imported images) without changing the view in the collections module

Isn't the purpose of the collections module to drive the view? I go to the collections module, filter to what I want to see and it shows up in the view.

Maybe we should open an RFC for how the collection module is supposed to function and then spin off separate issues to work when we identify things that are wanted and make sense to do.

If we don't go that route, then we should al least break up all the ideas in here to separate issues to work.

vancouverbluesea commented 2 weeks ago

If we don't go that route, then we should al least break up all the ideas in here to separate issues to work.

Not sure what is the process but if few issues are generated based on this thread - can re summarize what I am seeing if this helps.