search

darktable-org / dtdocs

darktable user manual
GNU General Public License v3.0
74 stars 74 forks source link

chromatic aberration documentation #264

Closed rawfiner closed 3 years ago

rawfiner commented 3 years ago

Documentation for chromatic aberration module. Please tell me if anything should be extended or if something is unclear :-)

rawfiner commented 3 years ago

also, git submodule update failed, it asks for a gitlab username, so I didn't try to build. I hope there is no formatting mistake in the markdown...

elstoc commented 3 years ago

also, git submodule update failed, it asks for a gitlab username

Odd. We moved the submodules off gitlab ages ago. Perhaps you need to init again?

rawfiner commented 3 years ago

Perhaps you need to init again?

That works! Sorry for the noise...

elstoc commented 3 years ago

Anyway this looks fine. I'll merge and copy-edit (will probably move the workflow section to the top) and I'll let you know if I need anything more. Thanks!

paperdigits commented 3 years ago

The .gitmodules file is tracked by git... Are you up to date with master?

On May 4, 2021 11:07:04 AM PDT, Chris Elston @.***> wrote:

also, git submodule update failed, it asks for a gitlab username

Odd. We moved the submodules off gitlab ages ago. Perhaps you need to init again?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/darktable-org/dtdocs/pull/264#issuecomment-832138367

rawfiner commented 3 years ago

Great thank you! Yes I was up to date, but I needed to deinit the submodule to init them again as the url changed since last time I used the project

elstoc commented 3 years ago

@rawfiner: I've pushed my copy-edit if you wanted to take a look at it.

rawfiner commented 3 years ago

Thank you, I took a look at it and it is perfect!